i3c: add i3c shell #70773
Merged
i3c: add i3c shell #70773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
previously approved these changes
Mar 27, 2024
XenuIsWatching
force-pushed
the
i3c-shell
branch
3 times, most recently
from
1c3b923
to
7b9c755
Compare
|
I've added a better subcmd which will autocomplete with only the possible I3C devices, as well as only I3C targets are either attached or within it's list. I've also added the i3c/i2c attach/reattach/detach shell commands Unfortunately for the I2C device list, there isn't an easy way to look up a string of the only addresses with in it's list. |
XenuIsWatching
force-pushed
the
i3c-shell
branch
3 times, most recently
from
9312548
to
ad42690
Compare
Closed
dcpleung
previously approved these changes
Apr 1, 2024
Add an I3C shell. This includes support of all I3C CCC commands that currently have helper functions implemented. This also includes all the read/write shell commands that the i2c shell supported. An Info command is also provided which will print out all i3c and i2c info of an i3c bus. Only SDR read/writes are currently implemented. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-shell
branch
from
ad42690
to
d35764f
Compare
dcpleung
approved these changes
Apr 3, 2024
dkalowsk
approved these changes
Apr 19, 2024
benner
reviewed
Apr 20, 2024
|
|
||
| if (argc > 4) { | ||
| num_bytes = strtol(argv[4], NULL, 16); | ||
| if (num_bytes > MAX_I3C_BYTES) { |
There was a problem hiding this comment.
nit: I suggest to let user know he/she was clamped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an I3C shell. This includes support of all I3C CCC commands that currently have helper functions implemented. This also includes all the read/write shell commands for SDR only that the i2c shell supported. An Info command is also provided which will print out all i3c and i2c info of an i3c bus.