posix: pthread: implement pthread_setschedprio #71001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonlight83340
force-pushed
the
pthread_setschedprio
branch
from
704e3d5
to
78edaf2
Compare
|
@moonlight83340 - probably one more test is needed under |
|
Will do that thank you ! (sorry, I close by misstake 😅 ) |
moonlight83340
force-pushed
the
pthread_setschedprio
branch
7 times, most recently
from
eb2bd1d
to
36dc0ce
Compare
cfriedt
reviewed
Apr 3, 2024
moonlight83340
force-pushed
the
pthread_setschedprio
branch
from
36dc0ce
to
54bc59c
Compare
cfriedt
reviewed
Apr 3, 2024
moonlight83340
force-pushed
the
pthread_setschedprio
branch
from
54bc59c
to
1f71687
Compare
ycsin
reviewed
Apr 4, 2024
lib/posix/options/pthread.c
Outdated
Comment on lines
879
to
882
| int ret = 0; | ||
| int new_prio = K_LOWEST_APPLICATION_THREAD_PRIO; | ||
| struct posix_thread *t = NULL; | ||
| int policy = 0; |
There was a problem hiding this comment.
I think only new_prio needs to be initialized?
There was a problem hiding this comment.
Suggested change
| int ret = 0; | |
| int new_prio = K_LOWEST_APPLICATION_THREAD_PRIO; | |
| struct posix_thread *t = NULL; | |
| int policy = 0; | |
| int ret = 0; | |
| int new_prio = K_LOWEST_APPLICATION_THREAD_PRIO; | |
| struct posix_thread *t = NULL; | |
| int policy; |
ret and t should be initialized I think.
There was a problem hiding this comment.
ret isn't used before L885 and will be assigned at L885
the initialization of t is probably required here, since it is used in L906
There was a problem hiding this comment.
Suggested change
| int ret = 0; | |
| int new_prio = K_LOWEST_APPLICATION_THREAD_PRIO; | |
| struct posix_thread *t = NULL; | |
| int policy = 0; | |
| int ret; | |
| int new_prio = K_LOWEST_APPLICATION_THREAD_PRIO; | |
| struct posix_thread *t = NULL; | |
| int policy; |
Implement posix pthread_setschedprio() Signed-off-by: Gaetan Perrot <gaetanperrotpro@gmail.com>
Add tests for pthread_setschedprio() Signed-off-by: Gaetan Perrot <gaetanperrotpro@gmail.com>
moonlight83340
force-pushed
the
pthread_setschedprio
branch
from
1f71687
to
e4ad4a0
Compare
cfriedt
reviewed
Apr 4, 2024
cfriedt
approved these changes
Apr 4, 2024
ycsin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that pthread_setschedprio() was mentioned in the documentation but hasn't actually been implemented yet :
https://github.com/search?q=repo%3Azephyrproject-rtos%2Fzephyr+setschedprio&type=code
Therefore, I decided to implement it based on the information provided here: :
https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_setschedprio.html