mgmt: hawkbit: autohandler and shell optimize #71037
Open
+132
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
b3e2f2d
to
34ccf08
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
34ccf08
to
839b1c2
Compare
12 tasks
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
839b1c2
to
28ce2f7
Compare
ycsin
requested changes
Apr 10, 2024
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
28ce2f7
to
4755f4d
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
4 times, most recently
from
3a04bdf
to
d7fcf8c
Compare
ycsin
reviewed
Apr 13, 2024
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
d7fcf8c
to
54b5308
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
2 times, most recently
from
01155a7
to
12df207
Compare
ycsin
reviewed
Apr 21, 2024
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
12df207
to
9803ac3
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
f423451
to
2b559e2
Compare
kartben
requested changes
Apr 24, 2024
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
2b559e2
to
55c4cdf
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
87085d1
to
47da142
Compare
ycsin
requested changes
Apr 29, 2024
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
47da142
to
8da445a
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
2 times, most recently
from
f946939
to
0cba492
Compare
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
3 times, most recently
from
9a6f7ec
to
84783a7
Compare
|
Rebased to resolve conflicts. |
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
2 times, most recently
from
e25718f
to
d3ed06d
Compare
aescolar
reviewed
May 7, 2024
There was a problem hiding this comment.
ok'ish for the release notes and migration guide.
Just a minor suggestion for improvement.
Though, if it were me, I would probably be less verbose and just list which new APIs have been added and rely on the link to their doxygen generated docs, instead of reexplaining it in the release notes.
aescolar
reviewed
May 7, 2024
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
4 times, most recently
from
83cfa48
to
5527168
Compare
staticly init hawkbit_work_handle Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
add option for autohandler to only run once. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Add hawkbit_autohandler_wait() to be able to wait for the autohandler to finish. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Also use a workqueue, when execution of hawkBit is requested via shell. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
If the run of the autohandler is started from shell, it will be logged. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Be able to delay the next run of the hawkbit autohandler. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Mention change of hawkbit autohandler and shell in the migration guide and the release notes. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
hawkbit_shell_optimize
branch
from
5527168
to
ee567b4
Compare
|
ping @ycsin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also use the workqueue for the run of hawkBit, when requested via the shell. This way the run via the shell will use the same thread as the autohandler run. We also can eliminate redundant code.
This has mainly the benefit of not having to extend the stack size of the shell threads. Explicitly when having multiple shell instances, then the stack of every instance has to be bigger.
This is needed for #70787 as it moves the buffers from global to the stack.