CHSC6X driver #71073

nicogou · 2024-04-03T22:39:15Z

Added a driver for the CHSC6X chip used on the Seeed Studio Round Display for Xiao

nicogou · 2024-04-03T22:46:58Z

Hi, I opened this PR in order to add the driver for the touch controller on the Seeed Studio Round display ( https://wiki.seeedstudio.com/get_start_round_display/ ), but my final goal is to add the display as a shield in Zephyr.
Should I wait for this PR to be merged and then open another one where I add the shield, or can I add the shield in this one ?
Thanks!
(Sorry if the question is dumb)

fabiobaltieri · 2024-04-04T07:34:10Z

Hi, I opened this PR in order to add the driver for the touch controller on the Seeed Studio Round display ( https://wiki.seeedstudio.com/get_start_round_display/ ), but my final goal is to add the display as a shield in Zephyr. Should I wait for this PR to be merged and then open another one where I add the shield, or can I add the shield in this one ? Thanks!

Separate PR is ideal, you can either wait or open the shield one already and just point out that this has to go in first, but if you are not in a hurry just do one at a time.

fabiobaltieri · 2024-04-04T07:41:47Z

@nicogou you have few compliance errors and a missing copyright line, you can also run compliance locally with ./scripts/ci/check_compliance.py

nicogou · 2024-04-04T09:40:03Z

@nicogou you have few compliance errors and a missing copyright line, you can also run compliance locally with ./scripts/ci/check_compliance.py

I made some changes that should resolve these.
I'll open a separate PR for the shield when I'm ready.

fabiobaltieri

could you also add an entry for this in tests/drivers/build_all/input/app.overlay? thanks

drivers/input/input_chsc6x.c

dts/bindings/input/seeed,chsc6x.yaml

drivers/input/input_chsc6x.c

nicogou · 2024-04-04T11:36:02Z

@fabiobaltieri Changes made, tested and pushed

drivers/input/input_chsc6x.c

dts/bindings/input/seeed,chsc6x.yaml

drivers/input/input_chsc6x.c

kartben · 2024-04-04T19:19:50Z

drivers/input/Kconfig.chsc6x

+	bool "Use out of tree CHSC6X capacitive touch panel driver"
+	default y
+	depends on DT_HAS_CHIPSEMI_CHSC6X_ENABLED
+	select GPIO
+	select I2C
+	help
+	  Enable out of tree driver for CHSC6X touch panel.


Suggested change

bool "Use out of tree CHSC6X capacitive touch panel driver"

default y

depends on DT_HAS_CHIPSEMI_CHSC6X_ENABLED

select GPIO

select I2C

help

Enable out of tree driver for CHSC6X touch panel.

bool "Use CHSC6X capacitive touch panel driver"

default y

depends on DT_HAS_CHIPSEMI_CHSC6X_ENABLED

select GPIO

select I2C

help

Enable driver for CHSC6X touch panel.

kartben · 2024-04-04T19:21:21Z

drivers/input/input_chsc6x.c

+		/* These events are generated for the LVGL touch implementation. */
+		input_report_abs(dev, INPUT_ABS_X, col, false, K_FOREVER);
+		input_report_abs(dev, INPUT_ABS_Y, row, false, K_FOREVER);
+		input_report_key(dev, INPUT_BTN_TOUCH, 1, true, K_FOREVER);
+	} else {
+		/* This event is generated for the LVGL touch implementation. */
+		input_report_key(dev, INPUT_BTN_TOUCH, 0, true, K_FOREVER);


Not sure I understand the mentions to LVGL?

kartben · 2024-04-04T19:27:31Z

dts/bindings/input/seeed,chsc6x.yaml

+      The irq signal defaults to active low as produced by the
+      sensor. The property value should ensure the flags properly
+      describe the signal that is presented to the driver.


This might have been copy-pasted from somewhere else but it looks like it's missing an actual description of the property?
See ex. https://docs.zephyrproject.org/latest/build/dts/api/bindings/input/focaltech%2Cft5336.html#dtbinding-focaltech-ft5336 or https://docs.zephyrproject.org/latest/build/dts/api/bindings/input/sitronix%2Ccf1133.html#dtbinding-sitronix-cf1133

kartben · 2024-04-04T19:31:12Z

dts/bindings/input/seeed,chsc6x.yaml

@@ -0,0 +1,14 @@
+description: CHSC6X touchscreen sensor


File has the wrong vendor in its name

nicogou · 2024-04-05T08:50:18Z

Made the requested changes

kartben · 2024-04-05T09:10:34Z

Made the requested changes

You might not have pushed them correctly, though :)

zephyrbot · 2024-04-05T09:55:18Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Added a driver for the CHSC6X chip used on the Seeed Studio Round Display for Xiao Signed-off-by: Nicolas Goualard <nicolas.goualard@sfr.fr>

nicogou · 2024-04-08T10:11:53Z

Made the requested changes

You might not have pushed them correctly, though :)

Indeed, just redid it, sorry

github-actions · 2024-04-08T13:29:20Z

Hi @nicogou!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Input Input Subsystem and Drivers labels Apr 3, 2024

zephyrbot requested review from fabiobaltieri, galak and gmarull April 3, 2024 22:39

zephyrbot assigned fabiobaltieri Apr 3, 2024

nicogou force-pushed the chsc6x-driver branch from dc0abe9 to 534843f Compare April 3, 2024 23:32

nicogou force-pushed the chsc6x-driver branch 2 times, most recently from b476daf to cad2bfb Compare April 4, 2024 09:15

fabiobaltieri reviewed Apr 4, 2024

View reviewed changes

drivers/input/input_chsc6x.c Outdated Show resolved Hide resolved

nicogou force-pushed the chsc6x-driver branch 2 times, most recently from d25be07 to 32e1272 Compare April 4, 2024 11:31

fabiobaltieri reviewed Apr 4, 2024

View reviewed changes

drivers/input/input_chsc6x.c Outdated Show resolved Hide resolved

dts/bindings/input/seeed,chsc6x.yaml Outdated Show resolved Hide resolved

nicogou force-pushed the chsc6x-driver branch 2 times, most recently from 7566696 to 191bab0 Compare April 4, 2024 13:10

fabiobaltieri reviewed Apr 4, 2024

View reviewed changes

drivers/input/input_chsc6x.c Outdated Show resolved Hide resolved

nicogou force-pushed the chsc6x-driver branch from 191bab0 to c1e889e Compare April 4, 2024 14:53

fabiobaltieri previously approved these changes Apr 4, 2024

View reviewed changes

fabiobaltieri requested review from faxe1008, danieldegrasse and bjarki-trackunit April 4, 2024 19:15

kartben requested changes Apr 4, 2024

View reviewed changes

carlescufi dismissed fabiobaltieri’s stale review via 42d3f8a April 5, 2024 09:54

zephyrbot added manifest manifest-net-tools labels Apr 5, 2024

zephyrbot requested review from dleach02, jukkar, mmahadevan108, pdgendt, rlubos, ssharks and tbursztyka April 5, 2024 09:55

drivers: input: CHSC6X Driver

4665f8b

Added a driver for the CHSC6X chip used on the Seeed Studio Round Display for Xiao Signed-off-by: Nicolas Goualard <nicolas.goualard@sfr.fr>

nicogou force-pushed the chsc6x-driver branch from 42d3f8a to 4665f8b Compare April 8, 2024 10:10

zephyrbot removed manifest manifest-net-tools labels Apr 8, 2024

jukkar removed their request for review April 8, 2024 10:23

fabiobaltieri approved these changes Apr 8, 2024

View reviewed changes

fabiobaltieri removed request for dleach02, mmahadevan108, pdgendt, rlubos, ssharks and tbursztyka April 8, 2024 12:55

kartben approved these changes Apr 8, 2024

View reviewed changes

nashif approved these changes Apr 8, 2024

View reviewed changes

nashif merged commit d9fd292 into zephyrproject-rtos:main Apr 8, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CHSC6X driver #71073

CHSC6X driver #71073

nicogou commented Apr 3, 2024

nicogou commented Apr 3, 2024 •

edited

fabiobaltieri commented Apr 4, 2024 •

edited

fabiobaltieri commented Apr 4, 2024

nicogou commented Apr 4, 2024

fabiobaltieri left a comment

nicogou commented Apr 4, 2024

kartben Apr 4, 2024

kartben Apr 4, 2024

kartben Apr 4, 2024

kartben Apr 4, 2024

nicogou commented Apr 5, 2024

kartben commented Apr 5, 2024 •

edited

zephyrbot commented Apr 5, 2024 •

edited

nicogou commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

CHSC6X driver #71073

CHSC6X driver #71073

Conversation

nicogou commented Apr 3, 2024

nicogou commented Apr 3, 2024 • edited

fabiobaltieri commented Apr 4, 2024 • edited

fabiobaltieri commented Apr 4, 2024

nicogou commented Apr 4, 2024

fabiobaltieri left a comment

Choose a reason for hiding this comment

nicogou commented Apr 4, 2024

kartben Apr 4, 2024

Choose a reason for hiding this comment

kartben Apr 4, 2024

Choose a reason for hiding this comment

kartben Apr 4, 2024

Choose a reason for hiding this comment

kartben Apr 4, 2024

Choose a reason for hiding this comment

nicogou commented Apr 5, 2024

kartben commented Apr 5, 2024 • edited

zephyrbot commented Apr 5, 2024 • edited

nicogou commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

nicogou commented Apr 3, 2024 •

edited

fabiobaltieri commented Apr 4, 2024 •

edited

kartben commented Apr 5, 2024 •

edited

zephyrbot commented Apr 5, 2024 •

edited