Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: dts: nordic: SysCtrl IPC configuration #71265

Merged
merged 3 commits into from
Apr 17, 2024
Merged

boards: dts: nordic: SysCtrl IPC configuration #71265

merged 3 commits into from
Apr 17, 2024

Conversation

57300
Copy link
Contributor

@57300 57300 commented Apr 9, 2024

Add DT nodes to be used for communicating with SysCtrl on nRF54H20.

@zephyrbot zephyrbot added platform: nRF Nordic nRFx area: Devicetree area: RISCV RISCV Architecture (32-bit & 64-bit) labels Apr 9, 2024
decsny
decsny reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add dts/common/nordic to the nrf platforms in the maintainer yml, I think this is why kumar was assigned, but it really should be the nordic maintainer assigned

@57300 57300 assigned anangl and unassigned galak Apr 10, 2024
@57300
Copy link
Contributor Author

57300 commented Apr 10, 2024

can you please add dts/common/nordic to the nrf platforms in the maintainer yml, I think this is why kumar was assigned, but it really should be the nordic maintainer assigned

Thanks for the suggestion. Updated maintainers and reassigned this PR.

anangl
anangl previously approved these changes Apr 10, 2024
View reviewed changes
@Rafal-Nordic Rafal-Nordic mentioned this pull request Apr 16, 2024
Merged
@57300
dts: nordic: nrf54h20: Add SysCtrl VEVIF node
801a13f 
Add a VEVIF node to be used for communicating with SysCtrl (cpusys).
This is the only part of the SysCtrl VPR exposed to local domains.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
@57300
boards: nordic: nrf54h20dk: Add IPC configuration for SysCtrl
f10a45e 
Add the default `zephyr,ipc-icmsg` nodes for communication with
Application and Radiocore.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
@57300
MAINTAINERS: Update nRF Platforms with new dts paths
7717dff 
Files in `dts/common/nordic` and `dts/riscv/nordic` belong to this area,
now that Nordic's devicetrees span multiple architectures. Use a glob to
cover all paths.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
@57300
Copy link
Contributor Author

57300 commented Apr 16, 2024

Rebased and added nodes for Radiocore <-> SysCtrl.

tmon-nordic
tmon-nordic approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@tmon-nordic tmon-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be some proper error message (instead of cryptic compile error) when zephyr,ipc-icmsg compatible (here: cpuapp_cpusys_ipc) has status = "okay"; but any of its mboxes (here: cpuapp_bellboard and cpusys_vevif) have status = "disabled";?

@57300
Copy link
Contributor Author

57300 commented Apr 16, 2024

Should there be some proper error message (instead of cryptic compile error) when zephyr,ipc-icmsg compatible (here: cpuapp_cpusys_ipc) has status = "okay"; but any of its mboxes (here: cpuapp_bellboard and cpusys_vevif) have status = "disabled";?

Sounds reasonable to me. I'm just not familiar enough with Zephyr IPC to know how and where this should be validated, if it isn't already.

@tmon-nordic
Copy link
Contributor

Should there be some proper error message (instead of cryptic compile error) when zephyr,ipc-icmsg compatible (here: cpuapp_cpusys_ipc) has status = "okay"; but any of its mboxes (here: cpuapp_bellboard and cpusys_vevif) have status = "disabled";?

Sounds reasonable to me. I'm just not familiar enough with Zephyr IPC to know how and where this should be validated, if it isn't already.

It is not validated. I stumbled across the cryptic error at

zephyr/subsys/ipc/ipc_service/backends/ipc_icmsg.c

Lines 59 to 60 in b4eac67

.mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \
.mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \

Not sure if the MBOX_DT_SPEC_INST_GET or DEFINE_BACKEND_DEVICE should get the check if the check is to be done at compile level. Alternative approach would be to make devicetree generator to check it. But I don't quite know what would be the correct place.

57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 17, 2024
@57300
[nrf fromlist] dts: nordic: nrf54h20: Add SysCtrl VEVIF node
b1d4ec7 
Upstream PR: zephyrproject-rtos/zephyr#71265

Add a VEVIF node to be used for communicating with SysCtrl (cpusys).
This is the only part of the SysCtrl VPR exposed to local domains.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit 801a13f8cf5c5b08908757b7e1f3b08d6b8ea667)
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 17, 2024
@57300
[nrf fromlist] boards: nordic: nrf54h20dk: Add IPC configuration for …
5dff2bf 
…SysCtrl

Upstream PR: zephyrproject-rtos/zephyr#71265

Add the default `zephyr,ipc-icmsg` nodes for communication with
Application and Radiocore.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit f10a45e62c19413e0dcbea881527436c3a87e387)
@aescolar aescolar merged commit e9562b6 into zephyrproject-rtos:main Apr 17, 2024
21 checks passed
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 19, 2024
@57300
[nrf fromlist] dts: nordic: nrf54h20: Add SysCtrl VEVIF node
3e2a573 
Upstream PR: zephyrproject-rtos/zephyr#71265

Add a VEVIF node to be used for communicating with SysCtrl (cpusys).
This is the only part of the SysCtrl VPR exposed to local domains.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit 801a13f8cf5c5b08908757b7e1f3b08d6b8ea667)
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 19, 2024
@57300
[nrf fromlist] boards: nordic: nrf54h20dk: Add IPC configuration for …
c27b7fb 
…SysCtrl

Upstream PR: zephyrproject-rtos/zephyr#71265

Add the default `zephyr,ipc-icmsg` nodes for communication with
Application and Radiocore.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit f10a45e62c19413e0dcbea881527436c3a87e387)
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 23, 2024
@57300
[nrf fromlist] dts: nordic: nrf54h20: Add SysCtrl VEVIF node
ec53181 
Upstream PR: zephyrproject-rtos/zephyr#71265

Add a VEVIF node to be used for communicating with SysCtrl (cpusys).
This is the only part of the SysCtrl VPR exposed to local domains.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit 801a13f8cf5c5b08908757b7e1f3b08d6b8ea667)
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 23, 2024
@57300
[nrf fromlist] boards: nordic: nrf54h20dk: Add IPC configuration for …
4a0172f 
…SysCtrl

Upstream PR: zephyrproject-rtos/zephyr#71265

Add the default `zephyr,ipc-icmsg` nodes for communication with
Application and Radiocore.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit f10a45e62c19413e0dcbea881527436c3a87e387)
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 25, 2024
@57300
[nrf fromlist] dts: nordic: nrf54h20: Add SysCtrl VEVIF node
9f57096 
Upstream PR: zephyrproject-rtos/zephyr#71265

Add a VEVIF node to be used for communicating with SysCtrl (cpusys).
This is the only part of the SysCtrl VPR exposed to local domains.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit 801a13f8cf5c5b08908757b7e1f3b08d6b8ea667)
57300 added a commit to 57300/sdk-zephyr that referenced this pull request Apr 25, 2024
@57300
[nrf fromlist] boards: nordic: nrf54h20dk: Add IPC configuration for …
229a3b5 
…SysCtrl

Upstream PR: zephyrproject-rtos/zephyr#71265

Add the default `zephyr,ipc-icmsg` nodes for communication with
Application and Radiocore.

Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
(cherry picked from commit f10a45e62c19413e0dcbea881527436c3a87e387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decsny decsny decsny left review comments

@anangl anangl anangl approved these changes

@tmon-nordic tmon-nordic tmon-nordic approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi is a code owner

@carlocaione carlocaione Awaiting requested review from carlocaione

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@galak galak Awaiting requested review from galak

@katsuster katsuster Awaiting requested review from katsuster

@kgugala kgugala Awaiting requested review from kgugala

@mgielda mgielda Awaiting requested review from mgielda

@npitre npitre Awaiting requested review from npitre

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

@ycsin ycsin Awaiting requested review from ycsin

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

Assignees

@anangl anangl

Labels
area: Devicetree area: Process area: RISCV RISCV Architecture (32-bit & 64-bit) platform: nRF Nordic nRFx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@57300 @tmon-nordic @anangl @decsny @galak @zephyrbot @aescolar