drivers: i3c: add getcaps support #71792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the sys_get_be* macros with ccc where it can be used. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
GETMXDS macros had typos in them. This fixes them. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-getcaps
branch
2 times, most recently
from
e444270
to
37a0142
Compare
dcpleung
previously approved these changes
Apr 22, 2024
XenuIsWatching
force-pushed
the
i3c-getcaps
branch
3 times, most recently
from
5cec6be
to
cd3f43f
Compare
dcpleung
previously approved these changes
Apr 24, 2024
XenuIsWatching
force-pushed
the
i3c-getcaps
branch
from
cd3f43f
to
df16cd8
Compare
dcpleung
reviewed
Apr 24, 2024
XenuIsWatching
force-pushed
the
i3c-getcaps
branch
from
df16cd8
to
b2be5dc
Compare
XenuIsWatching
force-pushed
the
i3c-getcaps
branch
2 times, most recently
from
0a74117
to
919c836
Compare
This adds the defines for getcaps format 1 and format 2. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Add reading of GETCAPS CCC in `i3c_device_basic_info_get`. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
Add a shell command for the CCC GETCAPS Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
GETSTATUS and GETMRL where not checking the right argc length. This corrects it to check for the right count. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
The CDNS will report a M0 error if the data length is not what it expects, but certain CCCs can have a variable length such as GETMXDS and GETCAPS. This sets it up to ignore the M0 error if it sees that ccc was GETMXDS or GETCAPS. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-getcaps
branch
from
919c836
to
5f675b2
Compare
|
I made a change to the GETCAPS (GETHDRCAP) is required to be supported for I3C v1.0 targets that support HDR |
dcpleung
approved these changes
Apr 25, 2024
carlescufi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for reading of the target's advanced capabilities based on if the BCR bit is set. This also nitpicks with cleaning up the ccc c file with using byte order macros. Also, fixes the MXDS macro typos.