scripts: size_report: Fixes and improvements #72316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix integer underflow bug on a section end address calculation causing incorrect address range for zero length sections and potential mistakes on symbol to memory area match. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Remove unused import to resolve pylint warning. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Read ELF headers only once for the size_report scirpt called for 'all' memory areas, consequently it executes 30-50% faster. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Don't set 'address' property for non-terminal nodes which are also shown in JSON footprint reports, thus to avoid confusion that a file or directory node has a continuous memory area allocated at some address and with the total size of all its associated child nodes which are likely scattered over different memory sections. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Report section name for symbols: both at json and text reports. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
golowanow
added
bug
Fix the memory footprint tree build for symbols with copies, e.g. static inline functions which are local per each compilation unit. Copies have the same path and symbol name, but different memory blocks associated, so they have to have separate nodes. Before the fix, these copies were merged into one node, with summary size and memory address of one of the symbols. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
golowanow
force-pushed
the
size_report_20240503
branch
from
dab207c
to
f3c6653
Compare
nashif
approved these changes
May 7, 2024
dcpleung
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes and improvements to
scripts/footprint/size_report- see details in the commit descriptions.