drivers: esp32: i2c: configure clock speed during runtime #72380
Conversation
maass-hamburg
commented
May 6, 2024
maass-hamburg
commented
- configure clock speed during runtime
- implement get_config of the i2c api
zephyrbot
requested review from
LucasTambor,
marekmatej,
sylvioalves,
teburd and
uLipe
maass-hamburg
force-pushed
the
esp32_i2c_config
branch
3 times, most recently
from
d88a62b
to
9a57437
Compare
|
ping @sylvioalves |
drivers/i2c/i2c_esp32.c
Outdated
| @@ -262,13 +261,13 @@ static int i2c_esp32_recover(const struct device *dev) | |||
| return 0; | |||
| } | |||
|
|
|||
| static void IRAM_ATTR i2c_esp32_configure_timeout(const struct device *dev) | |||
| static void IRAM_ATTR i2c_esp32_configure_timeout(const struct device *dev, uint32_t bitrate) | |||
There was a problem hiding this comment.
It sounds a bit strange to configure bit-rate in a configure_timeout function. I would either embed this into i2c_esp32_configure() or create a new i2c_esp32_configure_bitrate() function. How does it sound? I guess 1st option is a bit straighforward.
There was a problem hiding this comment.
fair point.
I now also moved the data mode part in a separate function, which is now only executed in the init, as it is set by the device tree and isn't changing during runtime.
maass-hamburg
force-pushed
the
esp32_i2c_config
branch
from
9a57437
to
6c68fbf
Compare
|
@maass-hamburg can you please squash the commits into a single one? |
maass-hamburg
force-pushed
the
esp32_i2c_config
branch
from
6c68fbf
to
687aece
Compare
@marekmatej is done. |
well, renaming the |
Be able to configure the clock frequency during runtime using `i2c_configure()` and be able to use `i2c_get_config()` of the i2c api for the esp32. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
esp32_i2c_config
branch
from
687aece
to
444ccf8
Compare
