boards: shields: Add shield for NXP's ov5640 camera modules #72434

ngphibang · 2024-05-07T21:35:50Z

This PR adds a shield for NXP's ov5640 camera modules which use a 44-pins board-to-board connector and MIPI CSI or DVP (parallel) inteface. These camera modules are made specifically for and provided together with NXP i.MX RT11xx EVK boards.

It is split from #69810 to ease the review process.

It already got some review from @danieldegrasse.

boards/shields/wuxi_ov5640/doc/index.rst

boards/shields/wuxi_ov5640/wuxi_ov5640.overlay

ngphibang · 2024-05-12T06:27:19Z

@danieldegrasse : Is it ok for you now ?
BTW, the PR is dependent on #71854 and #71859 and should be merged after them

ngphibang · 2024-05-14T22:22:17Z

As requested by @decsny and @dleach02, moved the commit that enables the video feature on RT1170 here as this PR can be considered as the last one which complete the feature.

dts/arm/nxp/nxp_rt11xx.dtsi

kartben

same as #72435 - I don't understand why the shield is being made nxp specific ; there should be a generic definition for the 42-pin connector ; see https://docs.zephyrproject.org/latest/hardware/porting/shields.html#gpio-nexus-nodes

boards/shields/wuxi_ov5640/wuxi_ov5640.overlay

danieldegrasse · 2024-05-21T16:50:11Z

@kartben what we have done in the past to handle (somewhat bespoke) connectors NXP has dreamed up is define a GPIO nexus node like nxp_mipi_connector: https://github.com/zephyrproject-rtos/zephyr/blob/master/boards/shields/rk055hdmipi4m/rk055hdmipi4m.overlay#L32. Would that work here?

kartben · 2024-05-22T14:41:16Z

@kartben what we have done in the past to handle (somewhat bespoke) connectors NXP has dreamed up is define a GPIO nexus node like nxp_mipi_connector: master/boards/shields/rk055hdmipi4m/rk055hdmipi4m.overlay#L32. Would that work here?

yes, that would be great :)

kartben · 2024-05-22T14:44:08Z

boards/shields/wuxi_ov5640/doc/index.rst

@@ -0,0 +1,68 @@
+.. _wuxi_ov5640:
+
+WUXI_OV5640 Camera Module


adding the same comment I just made on #72435 here too -- if this module is in fact NXP specific and not just a generic module with a 42-pin connector for the OV5640 one would get off Aliexpress like I initially assumed, then the README (and potentially the actual name of the shield) needs to reflect this better. If you also have a picture of the module and a link where people can order it and/or get the datasheet that would be even better to avoid any ambiguities.

@kartben Thanks for your comment. This camera module is a 44-pins board-to-board connector (e.g. Hirose DF40 series) provided together with the NXP's RT1170 EVK / EVKB and it seems we couldn't order it elsewhere.
After searching on the internet, it appears that this shield is NXP specific and not just a generic module. There is a similar camera module I found here but the pinouts are different.

Here are pictures of the camera module and the camera connector on i.MX RT1170 EVK.

I reworked the PR as your suggestions.

ngphibang · 2024-05-30T14:47:22Z

Forgot to change nxp_btb44_cam to nxp_btb44_ov5640 when references to the shield in boards/nxp/mimxrt1170_evk/doc/index.rst. Just fixed it. Sorry

kartben · 2024-05-30T14:54:18Z

boards/nxp/mimxrt1170_evk/mimxrt1170_evk_mimxrt1176_cm7.dts

+	/*
+	 * This node describes the GPIO pins mapping of the camera
+	 * connector, J2 on the EVK. This camera interface is supported
+	 * on several NXP RT11xx EVKs, and is used with several camera
+	 * modules available as zephyr shields, e.g. ov5640 module
+	 */
+	nxp_cam_connector: cam-connector {
+		compatible = "gpio-nexus";
+		#gpio-cells = <2>;
+		gpio-map-mask = <0xffffffff 0xffffffc0>;
+		gpio-map-pass-thru = <0 0x3f>;
+		gpio-map =	<9 0 &gpio11 15 0>,	/* Pin 9, RESETB */
+				<17 0 &gpio9 25  0>;	/* Pin 17, PWDN */
+	};
 };


As this will also be used for "several NXP RT11xx EVKs" (ex. RT1160 EVK as the exact same connector AFAICT), it would be better to define the GPIO nexus as its own compatible in dts/bindings/gpio (Iike e.g. arduino-header-r3 etc.). This is also an opportunity to document all the pins of the connector, not just 9 and 17 (again, see e.g arduino-header-r3 description for an example)

kartben · 2024-05-30T14:55:11Z

boards/shields/nxp_btb44_ov5640/doc/index.rst

+Overview
+********
+
+This shield supports ov5640 camera modules which use a 44-pins board-to-board connector and


Suggested change

This shield supports ov5640 camera modules which use a 44-pins board-to-board connector and

This shield supports ov5640 camera modules which use a 44-pin board-to-board connector and

boards/shields/nxp_btb44_ov5640/doc/index.rst

kartben · 2024-05-30T14:56:19Z

boards/shields/nxp_btb44_ov5640/doc/index.rst

+Requirements
+************
+
+This shield can only be used with a board which provides a 44-pins board-to-board


Suggested change

This shield can only be used with a board which provides a 44-pins board-to-board

This shield can only be used with a board which provides a 44-pin board-to-board

kartben · 2024-05-30T15:06:47Z

boards/shields/nxp_btb44_ov5640/doc/index.rst

+----------------------+--------------------+
+| Camera Connector Pin | Function           |
+======================+====================+
+| 1                    | AGND               |
+----------------------+--------------------+
+| 2                    | AF_GND             |
+----------------------+--------------------+
+| 3                    | STROBE             |
+----------------------+--------------------+
+| 4                    | AF_VCC             |
+----------------------+--------------------+
+| 5                    | SDA                |
+----------------------+--------------------+
+| 6                    | VCMSINK            |
+----------------------+--------------------+
+| 7                    | SCL                |
+----------------------+--------------------+
+| 8                    | AVDD               |
+----------------------+--------------------+
+| 9                    | RESETB             |
+----------------------+--------------------+
+| 10                   | GPIO1              |
+----------------------+--------------------+
+| 11                   | PCLK               |
+----------------------+--------------------+
+| 12                   | GPIO0              |
+----------------------+--------------------+
+| 13                   | VSYNC              |
+----------------------+--------------------+
+| 14                   | FREX               |
+----------------------+--------------------+
+| 15                   | HREF               |
+----------------------+--------------------+
+| 16                   | MIPI_CSI_DP1 / D9  |
+----------------------+--------------------+
+| 17                   | PWDN               |
+----------------------+--------------------+
+| 18                   | MIPI_CSI_DN1 / D8  |
+----------------------+--------------------+
+| 19                   | MIPI_CSI_DP1 / D9  |
+----------------------+--------------------+
+| 20                   | DGND               |
+----------------------+--------------------+
+| 21                   | MIPI_CSI_DN1 / D8  |
+----------------------+--------------------+
+| 22                   | MIPI_CSI_CLKP / D7 |
+----------------------+--------------------+
+| 23                   | MIPI_CSI_CLKP / D7 |
+----------------------+--------------------+
+| 24                   | MIPI_CSI_CLKN / D6 |
+----------------------+--------------------+
+| 25                   | MIPI_CSI_CLKN / D6 |
+----------------------+--------------------+
+| 26                   | DGND               |
+----------------------+--------------------+
+| 27                   | MIPI_CSI_DP0 / D5  |
+----------------------+--------------------+
+| 28                   | MIPI_CSI_DP0 / D5  |
+----------------------+--------------------+
+| 29                   | MIPI_CSI_DN0 / D4  |
+----------------------+--------------------+
+| 30                   | MIPI_CSI_DN0 / D4  |
+----------------------+--------------------+
+| 31                   | D3                 |
+----------------------+--------------------+
+| 32                   | DGND               |
+----------------------+--------------------+
+| 33                   | D2                 |
+----------------------+--------------------+
+| 34                   | XCLK               |
+----------------------+--------------------+
+| 35                   | D1                 |
+----------------------+--------------------+
+| 36                   | DVDD               |
+----------------------+--------------------+
+| 37                   | D0                 |
+----------------------+--------------------+
+| 38                   | DOVDD              |
+----------------------+--------------------+
+| 39                   | DGND               |
+----------------------+--------------------+
+| 40                   | DGND               |
+----------------------+--------------------+
+| 41                   | GND                |
+----------------------+--------------------+
+| 42                   | GND                |
+----------------------+--------------------+
+| 43                   | GND                |
+----------------------+--------------------+
+| 44                   | AF_GND             |
+----------------------+--------------------+


this would probably make sense to also add in the documentation of the new binding for nexus (again, see e.g. the description field of arduino-header-r3 as an example)

Add a shield for NXP ov5640 camera modules. This shield uses a 44-pin board-to-board connector which is supported on NXP RT1170 and RT1160 EVKs. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>

Enable video feature on cm7 evk and evkb which are tested with ov5640 camera. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>

dleach02 · 2024-06-10T13:26:58Z

@kartben can you return to this PR and confirm that @ngphibang has addressed your change requests?

ngphibang requested review from mmahadevan108 and dleach02 as code owners May 7, 2024 21:35

zephyrbot added platform: NXP NXP area: Shields Shields (add-on boards) labels May 7, 2024

zephyrbot requested review from avisconti, danieldegrasse, decsny, DerekSnell, EmilioCBen, erwango, jfischer-no, kartben and yvanderv May 7, 2024 21:36

zephyrbot assigned kartben May 7, 2024

danieldegrasse reviewed May 9, 2024

View reviewed changes

boards/shields/wuxi_ov5640/doc/index.rst Outdated Show resolved Hide resolved

boards/shields/wuxi_ov5640/wuxi_ov5640.overlay Outdated Show resolved Hide resolved

boards/shields/wuxi_ov5640/wuxi_ov5640.overlay Outdated Show resolved Hide resolved

ngphibang force-pushed the add_ov5640_shield branch from dac0ee6 to f84c03f Compare May 12, 2024 06:22

ngphibang force-pushed the add_ov5640_shield branch from f84c03f to c77649b Compare May 12, 2024 06:41

ngphibang mentioned this pull request May 12, 2024

boards: nxp: mimxrt1170_evk: Enable video feature #72632

Closed

DerekSnell removed their request for review May 13, 2024 14:06

danieldegrasse mentioned this pull request May 13, 2024

Add mipi csi2 rx driver #71859

Merged

ngphibang force-pushed the add_ov5640_shield branch from c77649b to 68891b4 Compare May 14, 2024 22:15

mmahadevan108 reviewed May 14, 2024

View reviewed changes

dts/arm/nxp/nxp_rt11xx.dtsi Outdated Show resolved Hide resolved

ngphibang force-pushed the add_ov5640_shield branch from 68891b4 to cf70300 Compare May 16, 2024 08:31

kartben requested changes May 21, 2024

View reviewed changes

kartben reviewed May 21, 2024

View reviewed changes

boards/shields/wuxi_ov5640/wuxi_ov5640.overlay Outdated Show resolved Hide resolved

kartben reviewed May 22, 2024

View reviewed changes

ngphibang force-pushed the add_ov5640_shield branch from 0553935 to cc5aa78 Compare May 27, 2024 19:21

ngphibang requested a review from kartben May 27, 2024 19:44

ngphibang force-pushed the add_ov5640_shield branch from cc5aa78 to 539cf36 Compare May 27, 2024 19:52

ngphibang mentioned this pull request May 27, 2024

Update and improve video capture sample #72633

Merged

ngphibang force-pushed the add_ov5640_shield branch from 539cf36 to 735d52f Compare May 30, 2024 13:54

ngphibang changed the title ~~boards: shields: Add shield for NXP's iMX RT11xx camera modules~~ boards: shields: Add shield for NXP's ov5640 camera modules May 30, 2024

ngphibang requested a review from danieldegrasse May 30, 2024 14:02

danieldegrasse previously approved these changes May 30, 2024

View reviewed changes

ngphibang dismissed danieldegrasse’s stale review via a62f652 May 30, 2024 14:42

ngphibang force-pushed the add_ov5640_shield branch from 735d52f to a62f652 Compare May 30, 2024 14:42

danieldegrasse previously approved these changes May 30, 2024

View reviewed changes

kartben requested changes May 30, 2024

View reviewed changes

ngphibang added 2 commits June 6, 2024 14:48

boards: shields: Add shield for NXP ov5640 camera modules

623f195

Add a shield for NXP ov5640 camera modules. This shield uses a 44-pin board-to-board connector which is supported on NXP RT1170 and RT1160 EVKs. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>

boards: nxp: mimxrt1170_evk: Enable video feature

26de560

Enable video feature on cm7 evk and evkb which are tested with ov5640 camera. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>

ngphibang dismissed danieldegrasse’s stale review via 26de560 June 6, 2024 12:49

ngphibang force-pushed the add_ov5640_shield branch from a62f652 to 26de560 Compare June 6, 2024 12:49

zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding platform: NXP Drivers NXP Semiconductors, drivers labels Jun 6, 2024

zephyrbot requested review from dbaluta, galak and manuargue June 6, 2024 12:49

ngphibang requested review from kartben and danieldegrasse June 6, 2024 13:02

danieldegrasse approved these changes Jun 6, 2024

View reviewed changes

dleach02 approved these changes Jun 6, 2024

View reviewed changes

dleach02 added this to the v3.7.0 milestone Jun 6, 2024

kartben approved these changes Jun 11, 2024

View reviewed changes

jhedberg merged commit 59af15a into zephyrproject-rtos:main Jun 11, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: shields: Add shield for NXP's ov5640 camera modules #72434

boards: shields: Add shield for NXP's ov5640 camera modules #72434

ngphibang commented May 7, 2024 •

edited

Loading

ngphibang commented May 12, 2024

ngphibang commented May 14, 2024

kartben left a comment

danieldegrasse commented May 21, 2024

kartben commented May 22, 2024

kartben May 22, 2024

ngphibang May 27, 2024 •

edited

Loading

ngphibang commented May 30, 2024 •

edited

Loading

kartben May 30, 2024

ngphibang Jun 6, 2024

kartben May 30, 2024

ngphibang Jun 6, 2024

kartben May 30, 2024

ngphibang Jun 6, 2024

kartben May 30, 2024

ngphibang Jun 6, 2024

dleach02 commented Jun 10, 2024

	This shield supports ov5640 camera modules which use a 44-pins board-to-board connector and
	This shield supports ov5640 camera modules which use a 44-pin board-to-board connector and

	This shield can only be used with a board which provides a 44-pins board-to-board
	This shield can only be used with a board which provides a 44-pin board-to-board

boards: shields: Add shield for NXP's ov5640 camera modules #72434

boards: shields: Add shield for NXP's ov5640 camera modules #72434

Conversation

ngphibang commented May 7, 2024 • edited Loading

ngphibang commented May 12, 2024

ngphibang commented May 14, 2024

kartben left a comment

Choose a reason for hiding this comment

danieldegrasse commented May 21, 2024

kartben commented May 22, 2024

Choose a reason for hiding this comment

ngphibang May 27, 2024 • edited Loading

Choose a reason for hiding this comment

ngphibang commented May 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dleach02 commented Jun 10, 2024

ngphibang commented May 7, 2024 •

edited

Loading

ngphibang May 27, 2024 •

edited

Loading

ngphibang commented May 30, 2024 •

edited

Loading