Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: gpio: Add support for Apollo3 SoCs GPIO #72438

Merged
merged 1 commit into from
May 15, 2024
Merged

drivers: gpio: Add support for Apollo3 SoCs GPIO #72438

merged 1 commit into from
May 15, 2024

Conversation

AlessandroLuo
Copy link
Contributor

This commit adds support for the GPIO which
can be found in Apollo3 SoCs

@AlessandroLuo
Copy link
Contributor Author

hi @henrikbrixandersen @mnkp, please help to review and approve this PR, thank you!

@aaronyegx
Copy link
Contributor

Hi @carlescufi , should the collaborators of Ambiq platform be requested review the affected soc/board/binding changes automatically by zephyrbot?

Ambiq Platforms:
status: odd fixes
collaborators:
- aaronyegx
- HaoLuo
- RichardSWheatley
files:
- soc/ambiq/
- boards/ambiq/apollo*/
- dts/arm/ambiq/
- dts/bindings//ambiq,
- drivers//ambiq
- drivers///ambiq
- drivers//*/apollo
labels:
- "platform: Ambiq"

@carlescufi
Copy link
Member

carlescufi commented May 8, 2024 •
edited

Hi @carlescufi , should the collaborators of Ambiq platform be requested review the affected soc/board/binding changes automatically by zephyrbot?

Yes, they should. Not sure why they aren't.

It's perhaps because you were not part of the GitHub team and org. I have now invited you all.

@AlessandroLuo
Copy link
Contributor Author

Hi @carlescufi, I have not received the invitation yet, maybe because my github username is different from that in MAINTAINERS.yml? could you please invite this account again? I'll update MAINTAINERS.yml later. thank you!

@henrikbrixandersen
Copy link
Member

Hi @carlescufi, I have not received the invitation yet, maybe because my github username is different from that in MAINTAINERS.yml? could you please invite this account again? I'll update MAINTAINERS.yml later. thank you!

These need to match up first. Please submit a PR for updating MAINTAINERS.yml.

@AlessandroLuo
Copy link
Contributor Author

@henrikbrixandersen created one here #72500

@swift-tk
Copy link
Contributor

swift-tk commented May 9, 2024 •
edited

@AlessandroLuo We may need to add CONFIG_GPIO=y in board default config due to the GPIO kconfig dependency loop issue.

The previous comment is dismissed as I should have found the cause of the problem. #72556

@swift-tk swift-tk mentioned this pull request May 10, 2024
Merged
4 tasks
@aaronyegx
Copy link
Contributor

The board changes look good to me.

swift-tk
swift-tk suggested changes May 10, 2024
View reviewed changes
drivers/gpio/gpio_ambiq.c Outdated Show resolved Hide resolved
boards/ambiq/apollo3_evb/apollo3_evb.dts Show resolved Hide resolved
drivers/gpio/gpio_ambiq.c Show resolved Hide resolved
drivers/gpio/gpio_ambiq.c Show resolved Hide resolved
drivers/gpio/gpio_ambiq.c Show resolved Hide resolved
drivers/gpio/gpio_ambiq.c Outdated Show resolved Hide resolved
drivers/gpio/gpio_ambiq.c Outdated Show resolved Hide resolved
drivers/gpio/gpio_ambiq.c Show resolved Hide resolved
@zephyrbot
Copy link
Collaborator

zephyrbot commented May 11, 2024 •
edited

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_ambiq zephyrproject-rtos/hal_ambiq@f6858cb zephyrproject-rtos/hal_ambiq@94dd874 zephyrproject-rtos/hal_ambiq@f6858cb3..94dd874c

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@AlessandroLuo
drivers: gpio: Add support for Apollo3 SoCs GPIO
3e7e983 
This commit adds support for the GPIO which
can be found in Apollo3 SoCs

Signed-off-by: Hao Luo <hluo@ambiq.com>
@AlessandroLuo
Copy link
Contributor Author

@henrikbrixandersen @mnkp any more comments? if not please help to approve, thank you!

aaronyegx
aaronyegx approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@aaronyegx aaronyegx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Board and device tree changes look good to me. @henrikbrixandersen @mnkp We would appreciate your review on the GPIO driver changes. Thanks.

@AlessandroLuo
Copy link
Contributor Author

Hi @carlescufi , should the collaborators of Ambiq platform be requested review the affected soc/board/binding changes automatically by zephyrbot?

Yes, they should. Not sure why they aren't.

It's perhaps because you were not part of the GitHub team and org. I have now invited you all.

Hi @carlescufi could you please invite me again, MAINTAINERS.yml has been updated correctly.

@RichardSWheatley RichardSWheatley self-requested a review May 13, 2024 16:46
@henrikbrixandersen henrikbrixandersen removed their assignment May 15, 2024
@carlescufi carlescufi merged commit a64b069 into zephyrproject-rtos:main May 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardSWheatley RichardSWheatley RichardSWheatley approved these changes

@aaronyegx aaronyegx aaronyegx approved these changes

@swift-tk swift-tk swift-tk approved these changes

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@mnkp mnkp Awaiting requested review from mnkp

Assignees
No one assigned
Labels
area: GPIO manifest manifest-hal_ambiq platform: Ambiq Ambiq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AlessandroLuo @aaronyegx @carlescufi @henrikbrixandersen @swift-tk @zephyrbot @RichardSWheatley