Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth samples: Fix broadcast source device name #72915

Merged
merged 1 commit into from
May 22, 2024

Conversation

jthm-ot
Copy link
Contributor

@jthm-ot jthm-ot commented May 17, 2024

The device name explicitly added in the advertising data.

Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I want to suggest that we, instead of having 2 advertising data sets (ad and ext_ad), we only keep one of them.

The device name explicitly added in the advertising data.

Signed-off-by: Jens Rehhoff Thomsen <jthm@demant.com>
@dleach02 dleach02 merged commit 1c70e87 into zephyrproject-rtos:main May 22, 2024
19 checks passed
larsgk added a commit to larsgk/zephyr that referenced this pull request Jun 11, 2024
Jens has contributed the following PRs

zephyrproject-rtos#68678
zephyrproject-rtos#72409
zephyrproject-rtos#72915
zephyrproject-rtos#73564
zephyrproject-rtos#73656

and is attending the weekly LE Audio Zephyr meetings.

Signed-off-by: Lars Knudsen <larsgk@gmail.com>
larsgk added a commit to larsgk/zephyr that referenced this pull request Jun 11, 2024
Jens has contributed the following PRs

zephyrproject-rtos#68678
zephyrproject-rtos#72409
zephyrproject-rtos#72915
zephyrproject-rtos#73564
zephyrproject-rtos#73656

and is attending the weekly LE Audio Zephyr meetings.

Signed-off-by: Lars Knudsen <LAKD@Demant.com>
jhedberg pushed a commit that referenced this pull request Jun 12, 2024
Jens has contributed the following PRs

#68678
#72409
#72915
#73564
#73656

and is attending the weekly LE Audio Zephyr meetings.

Signed-off-by: Lars Knudsen <LAKD@Demant.com>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Jun 13, 2024
Jens has contributed the following PRs

zephyrproject-rtos/zephyr#68678
zephyrproject-rtos/zephyr#72409
zephyrproject-rtos/zephyr#72915
zephyrproject-rtos/zephyr#73564
zephyrproject-rtos/zephyr#73656

and is attending the weekly LE Audio Zephyr meetings.

(cherry picked from commit 0923750)

Original-Signed-off-by: Lars Knudsen <LAKD@Demant.com>
GitOrigin-RevId: 0923750
Change-Id: Ic57e788e2dc4d5ae0dbbb0687bb23657c6c9f8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5629141
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants