-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth samples: Fix broadcast source device name #72915
Merged
dleach02
merged 1 commit into
zephyrproject-rtos:main
from
jthm-ot:work_broadcast_source
May 22, 2024
Merged
Bluetooth samples: Fix broadcast source device name #72915
dleach02
merged 1 commit into
zephyrproject-rtos:main
from
jthm-ot:work_broadcast_source
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
requested changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. I want to suggest that we, instead of having 2 advertising data sets (ad
and ext_ad
), we only keep one of them.
The device name explicitly added in the advertising data. Signed-off-by: Jens Rehhoff Thomsen <jthm@demant.com>
c98b49d
to
b7af23a
Compare
larsgk
approved these changes
May 21, 2024
Thalley
approved these changes
May 21, 2024
jhedberg
approved these changes
May 22, 2024
larsgk
added a commit
to larsgk/zephyr
that referenced
this pull request
Jun 11, 2024
Jens has contributed the following PRs zephyrproject-rtos#68678 zephyrproject-rtos#72409 zephyrproject-rtos#72915 zephyrproject-rtos#73564 zephyrproject-rtos#73656 and is attending the weekly LE Audio Zephyr meetings. Signed-off-by: Lars Knudsen <larsgk@gmail.com>
larsgk
added a commit
to larsgk/zephyr
that referenced
this pull request
Jun 11, 2024
Jens has contributed the following PRs zephyrproject-rtos#68678 zephyrproject-rtos#72409 zephyrproject-rtos#72915 zephyrproject-rtos#73564 zephyrproject-rtos#73656 and is attending the weekly LE Audio Zephyr meetings. Signed-off-by: Lars Knudsen <LAKD@Demant.com>
jhedberg
pushed a commit
that referenced
this pull request
Jun 12, 2024
coreboot-org-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Jun 13, 2024
Jens has contributed the following PRs zephyrproject-rtos/zephyr#68678 zephyrproject-rtos/zephyr#72409 zephyrproject-rtos/zephyr#72915 zephyrproject-rtos/zephyr#73564 zephyrproject-rtos/zephyr#73656 and is attending the weekly LE Audio Zephyr meetings. (cherry picked from commit 0923750) Original-Signed-off-by: Lars Knudsen <LAKD@Demant.com> GitOrigin-RevId: 0923750 Change-Id: Ic57e788e2dc4d5ae0dbbb0687bb23657c6c9f8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5629141 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device name explicitly added in the advertising data.