-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: Set min version of pylint to 3 #73152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR zephyrproject-rtos#72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 22, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 22, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 22, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
nashif
approved these changes
May 23, 2024
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 25, 2024
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file. Upstream PR: zephyrproject-rtos/zephyr#73152 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
henrikbrixandersen
approved these changes
May 26, 2024
jhedberg
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
The issue is a bug, or the PR is fixing a bug
priority: low
Low impact/importance bug
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #72592 made pylint to use json2 output format. However, this format is introduced in pylint v3. This commit adds an appropriate setting in the requirements file.