drivers: usb_c:: support Nuvoton's NuMaker M2L31 series #73635
Conversation
zephyrbot
added
platform: Nuvoton Numicro Numaker
zephyrbot
requested review from
cyliangtw,
decsny,
fabiobaltieri,
galak,
jackrosenthal,
kartben,
keith-zephyr,
nashif,
sambhurst and
sjg20
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
| description: | | ||
| Rate of timer-triggered EADC measurement (Hz). | ||
| This is ignored when none of above is specified. | ||
| default: 100 |
There was a problem hiding this comment.
default needs justification https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#rules-for-default-values
drivers/usb_c/tcpc/ucpd_numaker.c
Outdated
| } | ||
| NUMAKER_UTCPD_REG_WRITE_BY_NAME(dev, CMD, cmd); | ||
|
|
||
| cleanup: |
There was a problem hiding this comment.
This cleanup: labels should be removed along with the other in the file.
There was a problem hiding this comment.
Originally, goto cleanup is embedded in NUMAKER_UTCPD_REG_WRITE_BY_NAME. Now it is moved outside.
drivers/usb_c/tcpc/ucpd_numaker.c
Outdated
|
|
||
| cleanup: | ||
|
|
||
| return rc; |
There was a problem hiding this comment.
Just return 0. Same in other function.
|
|
||
| /* Functions below with name pattern "*_tcpc_ppc_*" are to invoke by NuMaker PPC driver */ | ||
|
|
||
| int numaker_tcpc_ppc_is_dead_battery_mode(const struct device *dev) |
There was a problem hiding this comment.
Are these wrapper functions necessary?
There was a problem hiding this comment.
yes, they are to be invoked by ppc/vbus drivers. tcpc driver implements all the functions to match UTCPD H/W
drivers/usb_c/ppc/usbc_ppc_numaker.c
Outdated
| }; | ||
|
|
||
| /* TCPC exported */ | ||
| int numaker_tcpc_ppc_is_dead_battery_mode(const struct device *dev); |
There was a problem hiding this comment.
These prototypes should be commented and placed in a header file.
There was a problem hiding this comment.
They are moved to one internal header file.
drivers/usb_c/tcpc/ucpd_numaker.c
Outdated
| */ | ||
|
|
||
| /* Invalid or missing value */ | ||
| #define NUMAKER_INVALID_VALUE ((uint32_t)-1) |
There was a problem hiding this comment.
UINT32_MAX is also an option
drivers/usb_c/tcpc/ucpd_numaker.c
Outdated
| enum adc_reference reference; | ||
|
|
||
| if (data->vref_mv) { | ||
| goto cleanup; |
There was a problem hiding this comment.
Remove goto cleanup and just return error value. Same in other functions
There was a problem hiding this comment.
Removed most goto cleanup, keep only needed
|
Please run clang-format and follow Zephyr Code Documentation |
drivers/usb_c/tcpc/ucpd_numaker.c
Outdated
| */ | ||
|
|
||
| /* Invalid or missing value */ | ||
| #define NUMAKER_INVALID_VALUE ((uint32_t)-1) |
There was a problem hiding this comment.
UINT32_MAX is also an option
Run |
drivers/usb_c/ppc/usbc_ppc_numaker.c
Outdated
| struct numaker_ppc_data { | ||
| uint32_t dummy; | ||
| }; |
There was a problem hiding this comment.
thanks, dropped this too
ccli8
force-pushed
the
nvt_m2l31_usb_c
branch
2 times, most recently
from
357b878
to
8ac4b7a
Compare
|
rebase on main to fix conflict |
|
@fabiobaltieri Please re-review if you are available |
1. Support USB-C drivers TCPC, PPC, and VBUS with UTCPD H/W IP 2. UTCPD is interconnected with Timer-triggered EADC for updating VBUS/VCONN voltage periodically Signed-off-by: Chun-Chieh Li <ccli8@nuvoton.com>
Add support for NuMaker-M2L31 board Signed-off-by: Chun-Chieh Li <ccli8@nuvoton.com>
|
Rebase on main to merge in #73632, which fixes |
This PR adds Nuvoton's NuMaker M2L31 series UTCPD support in usb_c: