net: context: connect: Make sure local end is bound before connecting #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This version supersedes #785 |
jukkar
requested changes
Jul 17, 2017
subsys/net/ip/net_context.c
Outdated
| /* If local address is not bound, bind it to INADDR_ANY and random port. */ | ||
| static int bind_default(struct net_context *context) | ||
| { | ||
| sa_family_t af = net_context_get_family(context); |
There was a problem hiding this comment.
Would prefer "family" instead of "af", as the family variable is used in other part of the code.
Introduce net_context_bind_default() to ensure that local address is set for context if not yet (via explict bind() call). This fixes dereferences of NULL pointer to local address which was exposed when MMU was enabled for qemu_x86. Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
pfalcon
force-pushed
the
net-default-bind2
branch
from
c78c92e
to
e1aeb28
Compare
jukkar
approved these changes
Jul 17, 2017
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
…rproject-rtos#817) The new ZJS_VALIDATE_ARGS macro and related macros are to be used at the top of any JerryScript C binding to verify the quantity and types of arguments, and return standard exceptions if there is a problem. The comments above the macros in zjs_util.h explain the details of how they are to be used. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce net_context_bind_default() to ensure that local address is
set for context if not yet (via explict bind() call). This fixes
dereferences of NULL pointer to local address which was exposed when
MMU was enabled for qemu_x86.
Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org