Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI with sanitycheck exceptions #9456

Merged
merged 2 commits into from Aug 16, 2018

Conversation

nashif
Copy link
Member

@nashif nashif commented Aug 15, 2018

Abort CI when something fails in the early steps.

Fixes #9446

@nashif nashif added the DNM This PR should not be merged (Do Not Merge) label Aug 15, 2018
@nashif nashif removed the request for review from andrewboie August 15, 2018 22:39
@nashif nashif force-pushed the sanitycheck_except branch 3 times, most recently from 1afc91e to e27d1d2 Compare August 16, 2018 01:10
Exit on exceptions with crashing.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Do not continue if intermediate steps fail.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@codecov-io
Copy link

Codecov Report

Merging #9456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9456   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files         212      212           
  Lines       25889    25889           
  Branches     5561     5561           
=======================================
  Hits        13508    13508           
  Misses      10123    10123           
  Partials     2258     2258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa0e00...e2e8231. Read the comment docs.

@nashif nashif changed the title DNM: fix CI with sanitycheck exceptions fix CI with sanitycheck exceptions Aug 16, 2018
@nashif nashif requested a review from galak August 16, 2018 02:09
@nashif nashif removed the DNM This PR should not be merged (Do Not Merge) label Aug 16, 2018
@nashif
Copy link
Member Author

nashif commented Aug 16, 2018

had too many issues not being caught in CI, merging asap

@nashif nashif merged commit 27b9e2e into zephyrproject-rtos:master Aug 16, 2018
@nashif nashif deleted the sanitycheck_except branch March 4, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants