Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use id instead of name to declare zeplin components #34

Closed
sayinserdar opened this issue Feb 25, 2021 · 4 comments
Closed

Use id instead of name to declare zeplin components #34

sayinserdar opened this issue Feb 25, 2021 · 4 comments

Comments

@sayinserdar
Copy link

It would be really nice if an identifier array is used instead of zeplinNames array.
Our team decided to change its naming convention and we have to change each components' name in our components.json. It would be smoother if it's based on id. 🥂

@yuqu
Copy link
Member

yuqu commented Feb 25, 2021

Hey, thanks for the suggestion.

We have started to support component ids after @zeplin/cli@1.1.0 release. Documentation is on review now, will be published soon. In the meantime, you can access to the branch to see latest documentation.

Zeplin VSCode Extension is also going to be updated to support zeplinIds field very soon, you can track it on zeplin/vscode-extension#112. There will be a command named Migrate Zeplin Component names to ids in configuration on the extension to convert all existing zeplinNames to their correspondent ids, I suggest you to use that command for a seamless migration.

@yuqu yuqu closed this as completed Feb 25, 2021
@PoisonousJohn
Copy link

@yuqu hi. I see that you've added zeplinIds key to the configuration file, and it seems to be working via the CLI. Yet VSCode extension doesn't work with it, it does not suggest any action for this key

image

@yuqu
Copy link
Member

yuqu commented Mar 24, 2021

@PoisonousJohn Hi, we just published a new release for VS Code Extension to address zeplinIds issues, could you update it and try again?

@yuqu
Copy link
Member

yuqu commented Mar 24, 2021

@sayinserdar As I mentinoned on my comment above, VS Code Extension now supports using component IDs instead of components names on Connected Components configuration file. Check it out on the revamped documentation.

You can use migrate command on the command palette to convert all existing zeplinNames to corresponding zeplinIds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants