Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check emoji tags when finding suggestions #23

Merged
merged 2 commits into from Oct 19, 2018
Merged

Check emoji tags when finding suggestions #23

merged 2 commits into from Oct 19, 2018

Conversation

yigitcanyurtsever
Copy link
Member

Fixes #22

@yigitcanyurtsever
Copy link
Member Author

On second thought, I think it'd be better to have a way to check tags along with aliases when searching. I'll update this PR.

@yigitcanyurtsever yigitcanyurtsever changed the title Add lowercased and underscored country description as an alias Check emoji tags when finding suggestions Oct 19, 2018
berkcebi
berkcebi approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@berkcebi berkcebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇫🇷

@yigitcanyurtsever yigitcanyurtsever merged commit a71882d into develop Oct 19, 2018
@yigitcanyurtsever yigitcanyurtsever deleted the feature/country-flag-improvements branch October 19, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkcebi berkcebi berkcebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yigitcanyurtsever @berkcebi