This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
zos-core npm package integration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now working! Needs merge and release of zeppelinos/zos-lib#6 before merging |
maraoz
changed the title
spalladino
reviewed
Mar 9, 2018
| event Withdrawal(address indexed wallet, uint256 value); | ||
| event NewDonation(address indexed donor, uint256 value, uint256 r, uint256 g, uint256 b); | ||
|
|
||
| function initialize(address owner) public { |
There was a problem hiding this comment.
This behaviour needs to be abstracted into a reusable module (not now, though)
test/Basil.test.js
Outdated
| }) | ||
|
|
||
| it('sets the right registry', async function () { | ||
| await this.basil.transferOwnership(proxyOwner, {from: owner}) |
There was a problem hiding this comment.
Why this call to transferOwnership in this test?
truffle.js
Outdated
| @@ -2,11 +2,20 @@ require('babel-register'); | |||
| require('babel-polyfill'); | |||
|
|
|||
| module.exports = { | |||
| mocha: { | |||
| bail: true, | |||
There was a problem hiding this comment.
Remove this option, so the CI can show all errors
truffle.js
Outdated
| networks: { | ||
| ropsten: { | ||
| host: "localhost", | ||
| host: 'localhost', |
There was a problem hiding this comment.
Ropsten on localhost:8545 seems like a particular configuration on your host. Should we remove this entry?
There was a problem hiding this comment.
I didn't make that change, I just changed " for '
|
And please squash-and-merge this commit when merging :-P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.