This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Run examples tests directly from root package.json (instead of travis) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Waiting for travis and I'll merge |
|
I think this is a bit messy. That there is a script which is running I can't think of an alternative atm so we can merge it until we have time to make it better. |
|
@frangio Would you like to create an issue to tidy this up in the future? |
spalladino
pushed a commit
to OpenZeppelin/openzeppelin-sdk
that referenced
this pull request
Aug 1, 2018
…ts-npm Run examples tests directly from root package.json (instead of travis)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the example's tests were ran by travis builds. this caused confusion with npm tests in root passing, but not passing in CI. This PR makes it more clear that example tests are ran together with the root tests.