Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification of zAuction config before an instance is created #23

Merged
merged 9 commits into from
Nov 11, 2021

Conversation

JamesEarle
Copy link
Contributor

No description provided.

src/configuration/index.ts Outdated Show resolved Hide resolved
src/utilities/zAuctionRouting.ts Outdated Show resolved Hide resolved
src/configuration/configuration.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Remscar Remscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much there except for a potential bug which can happen if a user ever creates more than one ZNS SDK.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/utilities/zAuctionRouting.ts Outdated Show resolved Hide resolved
src/utilities/zAuctionRouting.ts Outdated Show resolved Hide resolved
test/zAuctionRouting.test.ts Outdated Show resolved Hide resolved
@JamesEarle JamesEarle merged commit 08a4ed7 into master Nov 11, 2021
@Remscar Remscar deleted the je/configurable-config branch May 10, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants