Initial ZNS 1.1 changes #51
Conversation
# Conflicts: # src/index.ts
| ipfsGatewayUri: IPFSGatewayUri | ||
| ): Promise<DomainMetadata> => { | ||
| const registrar = await getRegistrarForDomain(hub, domainId); | ||
| const metadataUri = await registrar.tokenURI(domainId); | ||
| const metadata = await getMetadataFromUri(metadataUri, ipfsGatewayUri); |
There was a problem hiding this comment.
It might be a nice idea from now on to do the below for performance, even if this is only a few await statements
const promises = [ ... ] as const;
const [var1, var2, ...] = await Promise.all(promises);
There was a problem hiding this comment.
Can't do that since each promise relies on the last one.
There was a problem hiding this comment.
don't how I missed that, makes sense
| @@ -103,13 +104,13 @@ export const createInstance = (config: Config): Instance => { | |||
| lockStatus: boolean, | |||
| signer: ethers.Signer | |||
| ): Promise<ethers.ContractTransaction> => { | |||
| const registrar: Registrar = await getRegistrar(signer, config.registrar); | |||
| const hub: ZNSHub = await getHubContract(signer, config.hub); | |||
There was a problem hiding this comment.
I suppose you could simplify this even further by just having config.hub be a parameter to the action, and calling getHubContract inside the action, same for the other functions
There was a problem hiding this comment.
Not sure what the best pattern will be here yet, I think we'll need to do a refactor pass in the future after the launch.
Making the actions just take a registrar and then doing the domainId->registrar look up outside of them may be wiser.
Preliminary support for ZNS 1.1