Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helper function to generate Default Metadata #90

Merged
merged 7 commits into from
Jun 8, 2022

Conversation

Will-Hyde
Copy link
Contributor

generateDefaultMetadata accepts an instance of an apiClient and a domain name, from there it generates some default metadata for the domain.

Copy link
Contributor

@Remscar Remscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can merge this and then fix the image url in another PR

src/actions/generateDefaultMetadata.ts Outdated Show resolved Hide resolved
src/actions/generateDefaultMetadata.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Remscar Remscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested, looks great

@Will-Hyde Will-Hyde merged commit bf534cf into master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants