show unread count #337
Merged
show unread count #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik21
reviewed
Jan 27, 2023
src/platform-apps/channels/direct-message-members/index.test.tsx
Outdated
Show resolved
Hide resolved
| } = state; | ||
|
|
||
| return { | ||
| user, | ||
| allUnreadMessages: list.reduce((count, directMessage) => count + directMessage.unreadCount, 0), |
There was a problem hiding this comment.
to confirm - is this real time, or would the user have to reload to see unread count icons after receiving new message?
There was a problem hiding this comment.
we do not have realtime yet for dm's and also channels
hkhanouchi
previously approved these changes
Jan 30, 2023
Co-authored-by: Ratik Jindal <ratikjindal21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
render unread messages :
Why are we making this change?
How do I test this?
Key decisions and Risk Assessment:
Things to consider: