Use zero-api to search for mentionable users in a channel #338

dalefukami · 2023-01-31T20:37:56Z

This searches for mentionable users via the api endpoint rather than using the user list cached on the front end.

An endpoint has been created specifically for searching for mentionable users in a channel. Use it to be consistent with zero-web and other projects.

In a channel, try to @ mention someone. Ensure the suggestion box contains users you would expect to see.

How will this affect security? N/A
How will this affect performance? Will be slower than the stubbed version we have now.
Does this change any APIs? No

src/store/channels/api.ts

src/platform-apps/channels/util/api.ts

src/platform-apps/channels/message.tsx

src/platform-apps/channels/channel-view.tsx

Co-authored-by: mrval5 <102802882+mrval5@users.noreply.github.com>

dalefukami added 3 commits January 31, 2023 10:18

Make user mention search async

971c25f

Use the api endpoint to search for mentionable users

e127db5

Remove unused parameter and method

10dce2d

dalefukami requested a review from a team January 31, 2023 20:41

mrval5 suggested changes Feb 1, 2023

View reviewed changes

dalefukami and others added 3 commits February 1, 2023 08:01

Update src/store/channels/api.ts

34dedff

Co-authored-by: mrval5 <102802882+mrval5@users.noreply.github.com>

Pull mention search function out of Message component

cb80736

Add unit test to verify we're searching with the right data

fa98692

dalefukami merged commit d6b9246 into main Feb 1, 2023

dalefukami deleted the channel-mention-search/zos-74 branch February 1, 2023 15:46

Provide feedback