make sidekick opening interactive with storage

[mrval5]

What does this do?

• store the state of sidekick if it's open or closed.
• in case no value in the storage, we open the sidekick and we store the value.

Why are we making this change?

How do I test this?

Key decisions and Risk Assessment:

Things to consider:

1. How will this affect security?
2. How will this affect performance?
3. Does this change any APIs?

[dalefukami]

I may be interpreting the story incorrectly but should we also be making sure the correct tab is selected? Maybe you already have a follow up PR coming.

[AdamDotCom]

I noticed a sidekick animation flash.

To reproduce:

• Connect, minimize the sidekick
• Disconnect
• Connect, observe that the sidekick opens and closes

sidekick-flash.webm

I wonder if you'll have to reset the canStartAnimation state when a user disconnects?

[mrval5]

I may be interpreting the story incorrectly but should we also be making sure the correct tab is selected? Maybe you already have a follow up PR coming.

the story has nothing about the tab. I can create another task - PR for the tab.

[dalefukami]

the story has nothing about the tab

"When I open messenger, it should open in the same view as i last had it"

I would consider the tab I had selected to be part of the "same view"

[dalefukami]

Sorry, I should have been more clear. That was my interpretation. Do it whichever way you want. ;)

[mrval5]

the story has nothing about the tab

"When I open messenger, it should open in the same view as i last had it"

I would consider the tab I had selected to be part of the "same view"

not sure if you remember that we cloned the story (id 2, 214) to split the sidekick and messenger state to 2 stories
@AdamDotCom explained during the daily that this sprint we will work on the sidekick.

I'm a bit confused here. maybe better to work on both stories in the same time.

[dalefukami]

Ah, yeah, when we were talking about splitting the story my understanding was that we were splitting off remember the state of the chat window (which chat was open and if it was minimized/fullscreen, etc) and the sidekick. My interpretation was that the tabs in the sidekick are part of the sidekick. It's obviously a separate PR from this, but new story, same story, doesn't really matter. Just chat with Adam and make a choice. He's representing the user.