Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji #388

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Add emoji #388

merged 4 commits into from
Mar 6, 2023

Conversation

mrval5
Copy link
Contributor

@mrval5 mrval5 commented Mar 3, 2023

What does this do?

  • add emojis to channel and messenger.

Screenshot 2023-03-03 at 10 14 01

Why are we making this change?

How do I test this?

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@mrval5 mrval5 requested a review from a team March 3, 2023 09:15
src/components/message-input/emoji-picker.tsx Outdated Show resolved Hide resolved
src/components/message/text-to-emojis.tsx Outdated Show resolved Hide resolved
src/components/message-input/index.tsx Show resolved Hide resolved
src/components/message-input/emoji-picker.tsx Outdated Show resolved Hide resolved
@dalefukami
Copy link
Collaborator

For reference, here's the PR where we made the switch to utf characters: https://github.com/m3m3n70/zero-web/pull/624

@mrval5 mrval5 requested a review from dalefukami March 6, 2023 12:49
@mrval5 mrval5 merged commit a84bd6a into main Mar 6, 2023
@mrval5 mrval5 deleted the add-emoji branch March 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants