-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert gif from giphy #390
Conversation
A Giphy image is a url link and a non native file so we don't need to upload it. We should be sending this message to the chatChannels/:id/message endpoint. Having said that the chatChannels/:id/message needed to be adjusted to accept the giphy params. Related PR: https://github.com/m3m3n70/zero-api/pull/937 The call from the saga to send the image url might look like:
Outstanding questions:
|
--
|
6bb9e51
to
a2be37f
Compare
09e3915
to
cb5278f
Compare
cb5278f
to
895a7fd
Compare
I found a bug to mention users in the app (Dev, Prod). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test in the saga.test.ts
file for:
- sending a Giphy as it's own message
- sending a Giphy with text
The Giphy message is showing up twice in my local environment (screen capture included).
Screen.Recording.2023-03-08.at.23.41.52.mov