Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of cjs lib that causes errors in the tests #414

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

dalefukami
Copy link
Contributor

What does this do?

  1. This changes how we import the AudioReactRecorder component.
  2. Change a property type to the proper thing.

Why are we making this change?

We're seeing these errors when running the tests:

Warning: React.jsx: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.

It's related to how the tests transpile/load the library.

How do I test this?

  • Run the tests
  • Test sending an audio message

@dalefukami dalefukami requested a review from a team March 16, 2023 18:11
@dalefukami dalefukami merged commit e866f50 into main Mar 16, 2023
@dalefukami dalefukami deleted the fix-test-errors branch March 16, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant