Render UserAction popups relative to the right nodes #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalefukami
force-pushed
the
render-popup-referenced-to-node/zos-220
branch
from
471600f
to
d839f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Fixes the Notification popup and UserMenu popup to render relative to the activation nodes
Why are we making this change?
Match design better
How do I test this?
Click the Notification icon with the conversations open and closed. Verify the popup is relative to the notification icon.
Click the User Avatar with the Conversations open and closed. Verify again.
Notifications w/ conversation open:
Notifications w/ conversations closed:
User Menu w/ conversations open:
User Menu w/ conversations closed:
