Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request/Balancing]: Change the Level 1 SPH Length Restriction to 9.0m, and the Height to 6.0m #39

Closed
MystLeissa opened this issue Apr 15, 2022 · 13 comments · Fixed by #45
Assignees
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: obvious The situation is obvious, best practices used.

Comments

@MystLeissa
Copy link

Description of the new feature / enhancement

Allow Level 1 SPH to build planes. (I think you accidentally copied the height/length restrictions from the VAB, so it reads 9.0 Height and 6.0 Length - which is nearly impossible to construct a plane in (The Tails required for stability come to 6m on their own, not including other parts.)

Proposed technical implementation details

Simple Swap of Height and Length Values.

@github-actions
Copy link

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.

@zer0Kerbal zer0Kerbal added issue: config issue type work: obvious The situation is obvious, best practices used. type: fix Iterations on existing features or infrastructure. state: approved Approved to proceed. bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code labels Apr 15, 2022
@zer0Kerbal
Copy link
Owner

sheepish grin I don't have all that much experience with the runway except crashing into it.

Thank you @MystLeissa

just level 1? or

@zer0Kerbal zer0Kerbal added this to To do in 1.0.1.0-release via automation Apr 15, 2022
@zer0Kerbal zer0Kerbal added this to Needs triage in Flyswatter (Bug and Feature Triage) via automation Apr 15, 2022
@zer0Kerbal zer0Kerbal added this to the 1.0.1.0-release milestone Apr 15, 2022
@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Apr 15, 2022

Sizes for the launchpad are easy - L x W x H

so you are suggesting size = 9,6,6 - I have no issues with that - once I remember which is what, will swap them all)

are you willing to do the testing once I have an updated config for you to try?

			size = 15, 18, 15
			size = 20, 36, 23
			size = 30, 72, 28
			size = 45, 80, 33
			size = 75, 100, 38
			size = 100, 120, 45
			size = 125, 140, 49
			size = 150, 160, 54
			size = -1, -1, -1```

@zer0Kerbal
Copy link
Owner

research:

Stock default for both Runway and Launchpad is

		craftSizeLimit
		{
			size = 15, 20, 15
			size = 28, 36, 28
			size = -1, -1, -1
		}

image

now that we can correlate which slot in the array goes to which dimension

@zer0Kerbal
Copy link
Owner

How's this @MystLeissa ? 👁️‍🗨️ 🔍

		craftSizeLimit
		{
			// width, height, length
			size = 6, 6, 9
			size = 15, 15, 18
			size = 20, 23, 36
			size = 30, 28, 72
			size = 45, 33, 80
			size = 75, 38, 100
			size = 100, 45, 120
			size = 125, 49, 140
			size = 150, 54, 160
			size = -1, -1, -1

@zer0Kerbal
Copy link
Owner

looks like need to swap the launchpad as well:
engineeringReport-VAB

zer0Kerbal added a commit to zer0Kerbal/CustomBarnKit that referenced this issue Apr 15, 2022
@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Apr 15, 2022

@MystLeissa Would you kindly try this and see if it corrects this issue for you? Of course, please tell me here. Thank you!

Place it here <KSP_ROOT>/GameData/KGEx/Komplexity/Configs/
Runway.zip

here is the updated wiki page:
https://zer0kerbal.github.io/Komplexity/Buildings/Runway.html

@MystLeissa
Copy link
Author

MystLeissa commented Apr 15, 2022

Downloading the Test Patch now - I'll let you know in about 5 minutes.

Edit: I don't have KGEx Folder so I'm assuming it goes in the GameData/Komplexity/Patches Folder.

@MystLeissa
Copy link
Author

Ok So I have a little more feedback: Assuming your using a modified Fighter Design (Which I'm using Firespitter, which in general is SMALLER than the Vanilla Jets, but tends to have more parts), A Flyable Plane, needs ~0.5m extra on the width (for wingspan), beyond that it fixed the problem. For Reference I have included a picture of the plane I am attempting to use as a "Bare Minimal":
20220415175741_1

@MystLeissa
Copy link
Author

ok I solved the problem by changing the Array's First Level to 7w instead of the 6w you had, so I think that should work. I manually install so that's probably why the KGEx Folder didn't matter (plus my last update was prerelease so it's been some time), but yeah I think that's got it. it's not a perfect match for the launchpad, but then it doesn't need to be in my honest opinion, Planes are very different shapes from rockets.

@zer0Kerbal
Copy link
Owner

excellent. been ruminating over the numbers - and they go up way to fast imho.

@zer0Kerbal
Copy link
Owner

proposed:

			// wingspan(width), height, length
			size = 7, 6, 9
			size = 12, 12, 18
			size = 17, 17, 24
			size = 25, 24, 30
			size = 36, 31, 50
			size = 48, 39, 76
			size = 61, 48, 111
			size = 75, 68, 124
			size = 90, 88, 149
			size = -1, -1, -1

currently

// wingspan(width), height, length
			size = 6, 6, 9
			size = 12, 12, 18
			size = 24, 24, 36
			size = 48, 48, 72
			size = 72, 72, 100
			size = 96, 96, 120
			size = 100, 100, 130
			size = 125, 125, 140
			size = 150, 150, 172
			size = -1, -1, -1

@zer0Kerbal
Copy link
Owner

@MystLeissa thank you - here is an updated version. Kindly, same thing.

Runway.zip

zer0Kerbal added a commit that referenced this issue Apr 19, 2022
## Version 1.0.1.0-release `<Sideways Frontways>` edition

* 18 Apr 2022
* Released for Kerbal Space Program [KSP 1.12.x]

### Updated

* [Runway.cfg] v1.0.8.0
  * swap the length, width for the height restrictions for the runway
    * this because unlike the launchpad, planes are short, squat and very height challenged.
    * hardest part is to figure out which variable goes to which.
    * thank you to [MystLeissa](https://github.com/MystLeissa) for this suggestion
  * complete refactoring of length (x), height (y), and length (z) maximum allowable sizes
    * add label: // wingspan (width), height, length
    * consult [Runway](https://zer0kerbal.github.io/Komplexity/Buildings/Runway) for details
  * closes #39 - [Request/Balancing]: Change the Level 1 SPH Length Restriction to 9.0m, and the Height to 6.0m
* [Launchpad.cfg] v1.0.7.0
  * complete refactoring of length (x), height (y), and length (z) maximum allowable sizes
    * consult [Runway](https://zer0kerbal.github.io/Komplexity/Buildings/Runway) for details
  * closes #39 - [Request/Balancing]: Change the Level 1 SPH Length Restriction to 9.0m, and the Height to 6.0m
    * add label: // width, height, length
    * consult [Launchpad](https://zer0kerbal.github.io/Komplexity/Buildings/Launchpad) for details
  * closes #44 - Label and Swap the launchpad array
* [Komplexity.version]
  * since Komplexity will run on any version of Kerbal Space program
  * remove
    * KSP_VERSION_MIN

### Add

* Flags!
  * contributed by zer0Kerbal
  * closes #37 - Add Flag

#### docs/

* updated (in progress)
* add [Notices.md]
* docs/Buildings/
  * Updates
    * Full
      * [Administration.cfg] v1.1.0.0
    * Minor
      * [AstronautComplex.cfg] v1.0.6.1
      * [MissionControl.cfg] v1.0.5.1
      * [ResearchandDevelopment.cfg] v1.0.6.1
      * [SpaceplaneHanger.cfg] v1.0.6.1
      * [TrackingStation.cfg] v1.0.6.1
      * [VehicleAssemblyBuilding.cfg] v1.0.6.1

### Status

* Issues
  * closes #43 - 1.0.1.0 Social Media
  * closes #42 - 1.0.1.0 Update Documentation
  * closes #41 - 1.0.1.0 Verify Legal Mumbo Jumbo
  * closes #40 - Komplexity 1.0.1.0-release `<Sideways Frontways>

---
Flyswatter (Bug and Feature Triage) automation moved this from Needs triage to Closed Apr 19, 2022
1.0.1.0-release automation moved this from To do to Done Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: obvious The situation is obvious, best practices used.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants