Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 馃悶]: ELxxxSkill Log Spam #84

Closed
zer0Kerbal opened this issue Mar 22, 2022 · 2 comments 路 Fixed by #85 or #90
Closed

[Bug 馃悶]: ELxxxSkill Log Spam #84

zer0Kerbal opened this issue Mar 22, 2022 · 2 comments 路 Fixed by #85 or #90
Assignees
Labels
bug 馃悰 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type work: obvious The situation is obvious, best practices used.

Comments

@zer0Kerbal
Copy link
Owner

Brief description of your issue

``from: 馃懢
eightiesboi eightiesboi

KSP Forums

[ERR 16:24:52.448] ExperienceTrait: Cannot add effect 'ELSurveySkill' as it does not exist.
[ERR 16:24:52.448] ExperienceTrait: Cannot add effect 'ELConstructionSkill' as it does not exist.
[ERR 16:24:52.449] ExperienceTrait: Cannot add effect 'ELConstructionSkill' as it does not exist.
[ERR 16:24:52.449] ExperienceTrait: Cannot add effect 'ELSurveySkill' as it does not exist.
[ERR 16:24:52.450] ExperienceTrait: Cannot add effect 'ELConstructionSkill' as it does not exist.
[ERR 16:24:52.451] ExperienceTrait: Cannot add effect 'ELConstructionSkill' as it does not exist.
[ERR 16:24:52.451] ExperienceTrait: Cannot add effect 'ELConstructionSkill' as it does not exist.
[ERR 16:24:52.451] ExperienceTrait: Cannot add effect 'ELSurveySkill' as it does not exist.

And then I found this on the forums:

@EXPERIENCE_TRAIT[Pilot] {
    EFFECT {
        name = ELSurveySkill
    }
}

@EXPERIENCE_TRAIT[Engineer] {
    EFFECT {
        name = ELConstructionSkill
    }
}

What do you think?聽 What did I screw up... again?聽

Logs here: EL SC.zip

Steps to reproduce

  1. install SCON
  2. start the game
  3. read the KSP.log

Expected behavior

no spam 馃崫

No Spam :(

Actual behavior

spamming log

Spam in a can with black ham

Environment

latest

How did you download and install this?

CurseForge (download and manual installation)

@zer0Kerbal zer0Kerbal self-assigned this Mar 22, 2022
@zer0Kerbal zer0Kerbal added bug 馃悰 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type work: obvious The situation is obvious, best practices used. labels Mar 22, 2022
@zer0Kerbal zer0Kerbal added this to Needs triage in Flyswatter (Bug and Feature Triage) via automation Mar 22, 2022
@zer0Kerbal zer0Kerbal changed the title [Bug 馃悶]: [Bug 馃悶]: ELxxxSkill Log Spam Mar 22, 2022
@zer0Kerbal
Copy link
Owner Author

currently the patch reads like this:

@EXPERIENCE_TRAIT[Pilot]
{
	EFFECT
	{
		%name = ELSurveySkill
	}
}

@EXPERIENCE_TRAIT[Engineer]
{
	EFFECT
	{
		%name = ELConstructionSkill
	}
}

@zer0Kerbal
Copy link
Owner Author

it should read like this:

@EXPERIENCE_TRAIT[Pilot]
{
	EFFECT
	{
		name = ELSurveySkill
	}
}

@EXPERIENCE_TRAIT[Engineer]
{
	EFFECT
	{
		name = ELConstructionSkill
	}
}

@zer0Kerbal zer0Kerbal moved this from Needs triage to High priority in Flyswatter (Bug and Feature Triage) Mar 22, 2022
zer0Kerbal added a commit that referenced this issue Mar 22, 2022
* removed creeping crawler percent bugs '%' as reported by eightiesboi
* thank you to eightiesboi!
* fixes #84 - [Bug 馃悶]: ELxxxSkill Log Spam
zer0Kerbal added a commit that referenced this issue Mar 23, 2022
# Update

* [ExperienceTraits.cfg]
  * removed creeping crawler percent bugs '%' as reported by eightiesboi
  * thank you to [eightiesboi](https://forum.kerbalspaceprogram.com/index.php?/profile/133828-eightiesboi/)!
  * fixes #84 - [Bug 馃悶]: ELxxxSkill Log Spam
@zer0Kerbal zer0Kerbal linked a pull request Mar 23, 2022 that will close this issue
zer0Kerbal added a commit that referenced this issue Mar 23, 2022
# Fix 84 bug elxxxskill log spam

* [ExperienceTraits.cfg]
  * removed creeping crawler percent bugs '%' as reported by eightiesboi
  * thank you to [eightiesboi](https://forum.kerbalspaceprogram.com/index.php?/profile/133828-eightiesboi/)!
  * fixes #84 - [Bug 馃悶]: ELxxxSkill Log Spam
Flyswatter (Bug and Feature Triage) automation moved this from High priority to Closed Mar 23, 2022
zer0Kerbal added a commit that referenced this issue Mar 23, 2022
# Version 4.0.99.4-prerelease <% Bugs>

## Fixes

* [ExperienceTraits.cfg]
  * removed creeping crawler percent bugs '%' as reported by eightiesboi
  * thank you to [eightiesboi](https://forum.kerbalspaceprogram.com/index.php?/profile/133828-eightiesboi/)!
  * fixes #84 - [Bug 馃悶]: ELxxxSkill Log Spam

### Status

* Issues/Milestones
* closed #86 - SimpleConstruction! (SCON) 4.0.99.4-prerelease <% Bugs>
* closes #87 - 4.0.99.4 Verify Legal Mumbo Jumbo
* closes #88 - 4.0.99.4 Update DocumentationUTC
* closes #89 - 4.0.99.4 Social Media

* Pull Requests
  * closes #85 - 84 bug elxxxskill log spam - contributed by zer0Kerbal
  * closed #90 - SimpleConstruction! (SCON) 4.0.99.4-prerelease <% Bugs>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃悰 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type work: obvious The situation is obvious, best practices used.
Projects
No open projects
1 participant