Apidb reformatting #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we had syntax highlighting I'd be more inclined agree, but any editor I've seen will be using C++ syntax highlighting which won't do any SQL keyword highlighting. Using caps for SQL keywords is well established. The documentation of PostgreSQL uses this form, as does MySQL, sqlite and most others I've seen as well as most user-written documentation. |
The backend files were a mix of 3 space idents and 2 space indents, often in the same function. This commit moves to a consistent 2 space indent and makes a few else clauses use a consistent format.
No changes in the SQL, just whitespace and caps changes
No changes in meaning, just consistent AS names.
|
Might be worth checking this - there were some conflicts, and I tried to re-do the normalisation to 2-space indents, no tabs. But I might have missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various formatting improvements to the apidb files and SQL.
Add ?w=1 to the URL to hide whitespace changes.