Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] An optional remote job availability check in persons.json #759

Closed
abhishekakade opened this issue Oct 17, 2019 · 3 comments
Closed
Labels

Comments

@abhishekakade
Copy link
Contributor

Problem

A lot of people have been adding (Remote/Available anywhere for remote jobs, etc) to their country value in persons.json instead of just the country name.

Effects

This is causing country location fetches and map to fail as we are using the same country value in the restcountries API to add a marker on Google maps. And the country name value needs to be very accurate for the fetch request to succeed.

Solution

We should add a new optional key remote to every id to see if developers are interested in remote jobs with value as true/false. And then if the user has remote value, we can add it to their card on the job board.

@abhishekakade abhishekakade changed the title An optional remote job availability check in persons.json [Suggestion] An optional remote job availability check in persons.json Oct 17, 2019
@sophiabrandt
Copy link
Member

I think that's a good idea, but you will also have to adjust the previous data in persons.json.
Feel free to make an implementation and make a pull request.
Or anyone else who is interested!

@stale
Copy link

stale bot commented Jul 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.

@stale stale bot added the Stale label Jul 7, 2020
@stale
Copy link

stale bot commented Jul 14, 2020

This issue has been automatically closed because it has not had any recent activity. If your PR has a merge conflict, it must be resolved before it can be merged. Feel free to resolve and re-open Thank you for your contributions.

@stale stale bot closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants