Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code AutoFormatting #20

Closed
seijihariki opened this issue Nov 20, 2022 · 5 comments
Closed

Code AutoFormatting #20

seijihariki opened this issue Nov 20, 2022 · 5 comments

Comments

@seijihariki
Copy link
Collaborator

Hey, I think it would be of great interest of the project for us to define some code formatting guidelines to allow for usage of prettier or eslint for auto-formatting. I think this could help keep the code clean.

We can keep many of our current trends (semicolon use, although currently not consistent) and 4 space indentation, but I think some limits of line lengths could help make the code a bit more readable, for example.

@zero01101
Copy link
Owner

yeah consistency and clean code are NOT some of my strong points lol
good plan though 👍

@Kalekki
Copy link
Contributor

Kalekki commented Nov 20, 2022

https://github.com/marketplace/unibeautify-ci or a similar Github action could do the trick.

@seijihariki
Copy link
Collaborator Author

Thats actually the point!

We should have some guidelines to configure an automatic formatter so we don't have to worry about that anymore!

I'm also pretty bad at this without some magic autoformatting.

@zero01101
Copy link
Owner

zero01101 commented Nov 20, 2022

prettier looked nice :) i'm shamefully amateurish at Business-Quality Service Software™ like github and associated actions, so i've got some learning to do regarding setting up the action, but 5e49d18 is at least a start :)

@zero01101
Copy link
Owner

i think this works now? 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants