Restore waitForShutdown #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Mar 20, 2023
pepone
approved these changes
Mar 20, 2023
| @@ -37,7 +37,6 @@ public static int Main(string[] args) | |||
| // cts is canceled by Ctrl+C or a shutdown request. | |||
| // With C# 7.1 and up, you should make Main async and call: await Task.Delay(-1, cts.Token) | |||
| cts.Token.WaitHandle.WaitOne(); | |||
| communicator.shutdown(); | |||
There was a problem hiding this comment.
Don't we need this call to wait for the dispatches to finish?
There was a problem hiding this comment.
No, destroy aka Dispose calls shutdown.
bentoi
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores waitForShutdown in the asyncInvocation demo (see #186).
It also removes an unnecessary call to shutdown in the async demo. I don't see a way to meaningfully switch back to waitForShutdown in that demo.
See also #181.