Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimal C# demo #195

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update minimal C# demo #195

merged 1 commit into from
Oct 6, 2023

Conversation

bernardnormier
Copy link
Member

A small update to the minimal demo to make it more correct / cleaner.

@bernardnormier
Copy link
Member Author

See also #181.

@externl
Copy link
Member

externl commented Oct 5, 2023 •
edited
Loading

Do we care about de-sycnronizing (specifically renaming HelloI -> Printer) this one demo from the rest? Should we update all of the minimal demos?

pepone
pepone approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update other language mappings?

@bernardnormier
Copy link
Member Author

Yes, I am in favor of updating all the other minimal demos.

@bernardnormier bernardnormier merged commit 4c4f4e4 into zeroc-ice:3.7 Oct 6, 2023
1 check passed
@pepone pepone mentioned this pull request Oct 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepone pepone pepone approved these changes

@externl externl externl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bernardnormier @externl @pepone