Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 build fixes #1394

Merged
merged 2 commits into from Nov 3, 2022
Merged

Python 3.11 build fixes #1394

merged 2 commits into from Nov 3, 2022

Conversation

pepone
Copy link
Member

@pepone pepone commented Oct 30, 2022

Fixes for Python 3.11 build, Close #1393

@pepone pepone requested review from externl and bentoi October 30, 2022 16:03
externl
externl approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pepone pepone merged commit a98f34d into zeroc-ice:3.7 Nov 3, 2022
@markovendelin markovendelin mentioned this pull request Jul 13, 2023
Closed
chris-allan added a commit to chris-allan/zeroc-ice-py-macos-x86_64 that referenced this pull request Oct 12, 2023
@chris-allan
Add support for Python 3.11 (See zeroc-ice/ice#1394)
361b7f9 
This patch is nearly identical to
zeroc-ice/ice@4d1158b with the
exception that I have just removed the compile.h and eval.h header
inclusions.  They have not been required since Python 2.4 as they were
moved into Python.h.
@chris-allan chris-allan mentioned this pull request Oct 12, 2023
Merged
chris-allan added a commit to glencoesoftware/zeroc-ice-py-patches that referenced this pull request Oct 13, 2023
@chris-allan
Add support for Python 3.11 (See zeroc-ice/ice#1394)
73d8d5d 
This patch is nearly identical to
zeroc-ice/ice@4d1158b with the
exception that I have just removed the compile.h and eval.h header
inclusions.  They have not been required since Python 2.4 as they
were moved into Python.h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

@bentoi bentoi bentoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No eval.h in python 3.11
3 participants
@pepone @externl @bentoi