If there is no currentElement return from reposition #51

zeroclipboard · Dec 28, 2012 · 1e70c3c · 1e70c3c
1 parent fa6155b
commit 1e70c3c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/ZeroClipboard.js b/ZeroClipboard.js
@@ -113,6 +113,7 @@
     }
   };
   ZeroClipboard.Client.prototype.reposition = function() {
+    if (!ZeroClipboard.currentElement) return false;
     var pos = ZeroClipboard.getDOMObjectPosition(ZeroClipboard.currentElement);
     this.htmlBridge.style.top = pos.top + "px";
     this.htmlBridge.style.left = pos.left + "px";

diff --git a/ZeroClipboard.min.js b/ZeroClipboard.min.js
diff --git a/docs/releases.md b/docs/releases.md
@@ -8,6 +8,7 @@ This release re-writes a lot of how zeroclipboard client works. Check the docs f
 * [FEATURE] Register more than one event `.on("load complete", function() {})`
 * [FEATURE] Event handlers can now access the clicked element via `this`
 * [BUG] When creating more than one clip, the second clip doesn't glue.
+* [BUG] If there is no currentElement return from reposition #51
 
 ### ZeroClipboard 1.0.9
 

diff --git a/src/javascript/ZeroClipboard/client.js b/src/javascript/ZeroClipboard/client.js
@@ -233,6 +233,10 @@ ZeroClipboard.Client.prototype.setCurrent = function (element) {
  * returns nothing
  */
 ZeroClipboard.Client.prototype.reposition = function () {
+
+  // If there is no currentElement return
+  if (!ZeroClipboard.currentElement) return false;
+
   var pos = ZeroClipboard.getDOMObjectPosition(ZeroClipboard.currentElement);
 
   // new css