This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Deprecated '[un]glue', replaced with '[un]clip'. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| var htmlBridge = flashBridge && flashBridge.parentNode; | ||
| while (htmlBridge && isFlashElement.test(htmlBridge.tagName.toLowerCase()) && htmlBridge.parentNode) { | ||
| while (htmlBridge && isFlashElement.test(htmlBridge.nodeName) && htmlBridge.parentNode) { |
There was a problem hiding this comment.
Because nodeName is always uppercase: http://ejohn.org/blog/nodename-case-sensitivity/
|
cool, looks good. 💥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also had a bit of scope creep sneak in here in the form of event handling system enhancements:
onandoffEventListenerinterface support fordispatch's downstream functionsApplies partially to Issues #286 and #289 but does not fix either in whole.
You will likely notice a few changes within this PR that are suggestive of other incoming changes (e.g. renaming
flashStatemembersnoflash→disabledandwrongflash→outdated) that I didn't want to fully undo from my local changes.