This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
When dispatching MouseEvents to JS, should include pertinent Event details #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ZeroClipboard dispatches
MouseEvent
s to JavaScript, it is only sending an argument ofnull
rather than including any useful information. I'd love to see it pass along any pertinent Event details instead (e.g.ctrlKey
, etc.), though we may need to rely on the JS dispatcher to "correct" some of the properties, e.g. pass the Client'sid
for the eventtarget
but have the dispatcher change that into a DOM element.ActionScript MouseEvent details for events we currently dispatch:
JavaScript MouseEvent details: