Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

Only include dist/ in the bower package #447

Closed
wants to merge 1 commit into from

Conversation

aroben
Copy link
Contributor

@aroben aroben commented Jun 24, 2014

None of the other files are needed by consumers of this package.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4342263 on aroben:smaller-bower into 3cdb3f9 on zeroclipboard:master.

@JamesMGreene
Copy link
Member

I believe this can be simplified to something more like:

{
  "ignore": [
    "/**/*",
    "!bower.json",
    "!dist/*"
  ]
}

@JamesMGreene
Copy link
Member

@aroben Any chance you are able/willing to try such?

@aroben
Copy link
Contributor Author

aroben commented Jun 24, 2014

Yup, trying it out now. It looks like we currently do need to explicitly include bower.json. Bower 1.3.6 is supposed to make it impossible to ignore bower.json, but explicitly including it seems fine.

None of the other files are needed by consumers of this package.
@aroben
Copy link
Contributor Author

aroben commented Jun 24, 2014

@JamesMGreene Updated the branch to use much more concise rules.

@JamesMGreene
Copy link
Member

For my own edification, how did you test this out?

@aroben
Copy link
Contributor Author

aroben commented Jun 24, 2014

I tested by pushing the commit to my own fork, then using a bower.json that pointed to that fork/commit in its dependencies section and running bower install. Not a great workflow 😒. I probably could have pointed it at my local clone on disk to save a step.

@JamesMGreene
Copy link
Member

Thanks! Closed via f1b66db.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 958ab3c on aroben:smaller-bower into 3cdb3f9 on zeroclipboard:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants