Take element's scroll position into account when positioning html bridge #82
Take element's scroll position into account when positioning html bridge #82
Conversation
I didn't see any tests for positioning. I can add them if deemed necessary. |
I know @jonrohan wanted to add some positioning tests but you are correct that there aren't any currently. NodeUnit + JSDOM can't really give us what we need there, so we'll have to add PhantomJS to the testing tools for it. |
I had a feeling that was the case but didn't have time to look into it. |
Yeah, our current jsdom tests don't actually have any style or location data. which sucks a bit. so we don't have any tests. This looks good to me, I'd just say you should run |
Compiled. |
doh, now there's conflicts probably in ZeroClipboard.js and ZeroClipboard.min.js because of the last pr I just merged. |
Should I merge master and recompile? |
yeah give that a shot. |
Okay, now try? |
Take element's scroll position into account when positioning html bridge
excellent |
Any problems with a pull request that reverts this "fix" as it's breaking code as expressed in #93 and it doesn't include tests anyways. |
fine by me |
No description provided.