Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeopleTest.java:39-41: Add tests for details(), links(),... #840

Closed
0pdd opened this issue Mar 19, 2018 · 15 comments
Closed

PeopleTest.java:39-41: Add tests for details(), links(),... #840

0pdd opened this issue Mar 19, 2018 · 15 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 19, 2018

The puzzle 552-b158b0f7 from #552 has to be resolved:

* @todo #552:30min Add tests for details(), links(), wallet() and rate()
* in People.java because these methods are not fully covered. Then
* remove People.java from jacoco excludes in pom.xml

The puzzle was created by g4s8 on 12-Mar-18.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Mar 19, 2018

@yegor256/z please, pay attention to this issue

@0crat 0crat added the scope label Mar 19, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 19, 2018

Job #840 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 19, 2018

The job #840 assigned to @t-izbassar/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat
Copy link
Collaborator

0crat commented May 24, 2018

@t-izbassar/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@t-izbassar
Copy link
Contributor

@0crat wait for #1046 to be merged

@0crat
Copy link
Collaborator

0crat commented May 25, 2018

@0crat wait for #1046 to be merged (here)

@t-izbassar The impediment for #840 was registered successfully by @t-izbassar/z

t-izbassar pushed a commit to t-izbassar/farm that referenced this issue May 28, 2018
@t-izbassar
Copy link
Contributor

@0pdd fixed in #1046

@0pdd
Copy link
Collaborator Author

0pdd commented May 30, 2018

The puzzle 552-b158b0f7 has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Collaborator Author

0pdd commented May 30, 2018

@0pdd the puzzle #1059 is still not solved.

@0crat
Copy link
Collaborator

0crat commented May 30, 2018

@ypshenychka/z please review this job completed by @t-izbassar/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label May 30, 2018
@0crat
Copy link
Collaborator

0crat commented May 30, 2018

The job #840 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented May 30, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @t-izbassar/z

@0crat
Copy link
Collaborator

0crat commented May 30, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator Author

0pdd commented Jun 24, 2018

@0pdd the only puzzle #1059 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants