fixes in rebrand #34

kalbhor · 2023-09-27T12:16:51Z

This MR adds changes in the rebrand branch. These changes include:

Replacing default logger with slog.Logger everywhere
Bug fixes (loop variable capture, missing error checks & missing state conversion)
Add additional debug logs in http.go

cmd/config.sample.toml

cmd/http.go

* fix: missing error checks and state inconsistencies * fix: minor lint changes and remove unused constants * fix: query mapping bug * refactor: replace default logger with slog * fix: read config.toml in init * refactor: use chi middleware for debug logs * tests: add slow query test case * chore: add sample config file * fix: bump tasqueue and fix job result count --------- Co-authored-by: Lakshay Kalbhor <lakshay.kalbhor@zerodha.com>

Lakshay Kalbhor added 5 commits September 26, 2023 12:43

fix: missing error checks and state inconsistencies

6063c32

fix: minor lint changes and remove unused constants

64768d9

fix: query mapping bug

0c9bc26

refactor: replace default logger with slog

229b844

fix: read config.toml in init

f89b4c7

knadh reviewed Sep 27, 2023

View reviewed changes

cmd/config.sample.toml Outdated Show resolved Hide resolved

knadh reviewed Sep 27, 2023

View reviewed changes

cmd/http.go Outdated Show resolved Hide resolved

Lakshay Kalbhor added 4 commits September 28, 2023 15:59

refactor: use chi middleware for debug logs

cb2bec1

tests: add slow query test case

a8c779d

chore: add sample config file

c38aa0f

fix: bump tasqueue and fix job result count

66284ed

knadh merged commit 1fc867b into zerodha:rebrand Dec 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes in rebrand #34

fixes in rebrand #34

kalbhor commented Sep 27, 2023

fixes in rebrand #34

fixes in rebrand #34

Conversation

kalbhor commented Sep 27, 2023