Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames without timestamp cause crash #7

Closed
utack opened this issue Oct 29, 2017 · 5 comments
Closed

Frames without timestamp cause crash #7

utack opened this issue Oct 29, 2017 · 5 comments

Comments

@utack
Copy link

utack commented Oct 29, 2017

Hi,
I have recently encountered a stream with some images that have no timestamp.

Example:
<frame media_type="video" stream_index="3" key_frame="1" pkt_size="23754" width="600" height="882" pix_fmt="yuvj444p" pict_type="I" coded_picture_number="0" display_picture_number="0" interlaced_frame="0" top_field_first="0" repeat_pict="0" color_range="pc" color_space="bt470bg" chroma_location="center"/>
This happens when frames are attached:
screenshot_20171029_143818

According to ffmpeg docs you need to use "V" as stream option instead of "v" from the current "video" option to ignore attachments.
This fixes the problem

Thank you

@zeroepoch
Copy link
Owner

It's annoying that 'A' doesn't also work for audio. I'll have to change how it sets this option since I was just using the first char from the steam option before.

@utack
Copy link
Author

utack commented Oct 30, 2017

Yes, I wanted to leave it up to you if you want to do "audio" "Video" or something that checks for "v" and makes it caps

@zeroepoch
Copy link
Owner

I'll probably just use an if/else to be clear rather than some wierd single line command. It's going to take me a week or so to get it changed due to other things going on in my life this week.

@zeroepoch
Copy link
Owner

If you get a chance try it out and confirm it's working with your example file.

@utack
Copy link
Author

utack commented Nov 18, 2017

Works now, it ignores the attached images and processes the video frames
Thanks for fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants