TeaPadding does not understand #readStream

[fortizpenaloza]

Hi,

I registered the following routes:

GET -> '/data-streams/identifier:IsUUID/data-points'
GET -> '/data-streams'
GET -> '/data-streams/identifier:IsUUID'

and performing a GET on '/data-streams' I've got a MNU from TeaPadding.

IsUUID implementation of #matchesTo: and IsInteger look alike, I changed the regex pattern.

In the stack I found a TeaRequestMatcher trying to match the request's URL '/data-streams' to '/data-streams/identifier:IsUUID/data-points' by padding the segments of the first one and getting the following collection ('data-streams', TeaPadding, TeaPadding).

Then tries to match them from left to right until it gets the MNU trying to match the type constraint IsUUID to the first TeaPadding.

I think I can easily fix it by changing the IsUUID class>>#matchesTo: implementation taking into account that a TeaPadding can show up but I find hard to image that I'm the first one running into this issue.

Am I missing something?

[zeroflag]

@fortizpenaloza, good catch. I'll fix this in TeaPlaceholder>>matches:rest:placeholders: so there is no need to put custom logic into the type constraint class.

[zeroflag]

Name: Teapot-Core-AttilaMagyar.88
Author: AttilaMagyar
Time: 8 October 2018, 2:40:04.571123 pm
UUID: 5cc34aa8-1834-0d00-93a5-4b020d58bc98
Ancestors: Teapot-Core-TorstenBergmann.87

fix for issue: #3

Name: Teapot-Tests-AttilaMagyar.59
Author: AttilaMagyar
Time: 8 October 2018, 2:40:51.739428 pm
UUID: 70821aab-1834-0d00-93a6-70930d58bc98
Ancestors: Teapot-Tests-AttilaMagyar.58

fix for issue: #3 (tests)

You can try it out by loading the latest version.

Gofer it
    smalltalkhubUser: 'zeroflag' project: 'Teapot';
    configuration;
    loadDevelopment.

[fortizpenaloza]

Thanks!

[zeroflag]

you're welcome

…

On Mon, Oct 8, 2018 at 11:09 PM Francisco Ortiz Peñaloza < ***@***.***> wrote: Thanks! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnJVfvzHGhHzYyI32Ts0PAtXroqghLjks5ui77sgaJpZM4XMPMP> .

[gcotelli]

Any idea when this will land a release?

Have you consider migrating the sources to this repository? With https://github.com/peteruhnak/git-migration it's possible to preserve the history. I think it's easier to collaborate here that using SmalltalkHub and you can use the TravisCI integration support for automated testing. In case you're interested and need help with the migration just let me know.

[zeroflag]

@gcotelli I want to fix #4 before the release. And yes, eventually the project source code will be migrated to github.