Skip to content

Commit

Permalink
chore - fix golangci-lint version to match test version
Browse files Browse the repository at this point in the history
- letting golangci-lint pull latest even if the code isn't tested
  against that version is causing lint issues.

- fixing the versions will allow us to test both before we allow
  support for newer go versions
  • Loading branch information
Xopherus committed May 17, 2024
1 parent d4ac629 commit a95f5e2
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 8 deletions.
28 changes: 24 additions & 4 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,32 @@
name: golangci-lint
on: [push, pull_request]
on:
push:
branches:
- main
- master
pull_request:

permissions:
contents: read

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
strategy:
matrix:
include:
- go-version: 1.17.x
lint-version: v1.44.2
- go-version: 1.18.x
lint-version: v1.47.3
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v6
with:
version: latest
args: -v
version: ${{ matrix.lint-version }}
5 changes: 1 addition & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
linters:
disable-all: true
presets:
- format
run:
skip-dirs:
- vendor
- format

0 comments on commit a95f5e2

Please sign in to comment.