Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go issue 16206 #1298

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix: go issue 16206 #1298

merged 1 commit into from
Dec 7, 2021

Conversation

BYT0723
Copy link
Contributor

@BYT0723 BYT0723 commented Dec 5, 2021

p2c.subConn int64字段未对其，导致在Pick中choose(p.conns[0], nil)报错，p2c.go:153

kevwan
kevwan approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevwan kevwan merged commit af3fb2b into zeromicro:master Dec 7, 2021
@RanchoCooper
Copy link

不是很懂，这里字段定义顺序会有什么影响？

@BYT0723
Copy link
Contributor Author

BYT0723 commented Dec 7, 2021

不是很懂，这里字段定义顺序会有什么影响？

https://pengrl.com/p/21030/
32位系统int64初始化要求地对齐的，subConn初始化，上面一个结构图和接口先分配内存，不能保证下面的int64地址无误的，这个是go的问题。

@BYT0723 BYT0723 deleted the goIssue16206 branch December 7, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BYT0723 @RanchoCooper @kevwan