Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit missing method for redis #1325

Merged
merged 6 commits into from
Dec 15, 2021
Merged

commit missing method for redis #1325

merged 6 commits into from
Dec 15, 2021

Conversation

CrazyZard
Copy link
Contributor

commit missing method decr decrby lindex

@kevwan
Copy link
Contributor

kevwan commented Dec 14, 2021

Thanks for your PR!

Please add unit tests for redis commands. And put the functions in alphabetical order.

Thanks.

@kevwan kevwan self-requested a review December 14, 2021 07:59
@kevwan kevwan added the feature Marks an issue or PR as related to a new feature. label Dec 14, 2021
@CrazyZard
Copy link
Contributor Author

i've already done a code-review
thanks

kevwan
kevwan approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CrazyZard
Copy link
Contributor Author

goods news

@kevwan kevwan merged commit a7bd993 into zeromicro:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
feature Marks an issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CrazyZard @kevwan