Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix redis try-lock bug #1366

Merged
merged 1 commit into from
Dec 25, 2021
Merged

fix redis try-lock bug #1366

merged 1 commit into from
Dec 25, 2021

Conversation

peasfarmer
Copy link
Contributor

fix redis try-lock bug
#issue_id: 1338

fix redis try-lock bug
9928b2e 
#issue_id: 1338
@kevwan kevwan self-requested a review December 25, 2021 08:27
@kevwan
Copy link
Contributor

kevwan commented Dec 25, 2021

Thanks for your PR!

I think we don't need re-entrant lock. panic on locking again seems reasonable.

@kevwan kevwan linked an issue Dec 25, 2021 that may be closed by this pull request
redis锁重入bug #1338
Closed
@kevwan kevwan added the enhancement New feature or request label Dec 25, 2021
kevwan
kevwan approved these changes Dec 25, 2021
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevwan kevwan merged commit 836726e into zeromicro:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redis锁重入bug
2 participants
@peasfarmer @kevwan